SQL Server上的语法错误

Question

这可能是一个愚蠢的语法错误，但我只是继续阅读我的程序，但我无法弄清楚我的错误在哪里。

消息156，第15级，状态1，第41行
关键字“FOR”附近的语法不正确。

这是我的代码：

alter procedure LockReservation as
DECLARE @edition_id tinyint, @stockid  tinyint;
DECLARE @creservation CURSOR FOR select edition_id from reservation where (date_fin - GETUTCDATE()) <= 12;
open creservation;
while @@fetch_status = 0
BEGIN
    fetch creservation into @edition_id;
    DECLARE @cstock CURSOR 
        FOR select id from stock where edition_id = @edition_id;
    open cstock;
    while @@fetch_status = 0
    BEGIN
        fetch cstock into @stockid;
        select stock_id from location where location.stock_id = @stockid and archivage = 0
        if @@rowcount = 0
        BEGIN
             insert into stocks_reserves(id, date_ajout, usure, suppression, edition_id) 
                    Select id, date_ajout, usure, suppression, edition_id 
                from stock 
                where stock.id = @stockid
        END
    END
    CLOSE cstock
    DEALLOCATE cstock
END
CLOSE creservation
DEALLOCATE creservation

有人能帮助我吗？

Answer 1

不要在光标名称中使用@符号。

Answer 2

摆脱光标 - 使用基于集合的解决方案。

基本上你这样做：

insert into stocks_reserves
(id, date_ajout, usure, suppression, edition_id) 
Select id, date_ajout, usure, suppression, edition_id 
from stock 
where stock.id in
(
    select stock_id 
    from location 
    where location.stock_id in
    (
        select id 
        from stock 
        where edition_id in
        (
            select edition_id 
            from reservation 
            where (date_fin - GETUTCDATE()) <= 12
        )
    )
    and archivage = 0
)

您可以使用exists替换IN以更快地处理插入。

更好的是， INNER JOIN可能是最好的表现。

Answer 3

将游标名称命名为@creservation

Answer 4

在DECLARE @cstock CURSOR语句中删除光标名称前面的@符号