使用RSpec和存根的故障测试控制器

Question

我很难通过before_filters，异常以及一些模拟和存根来测试我的控制器。 这是控制器：

before_filter :get_subject, :only => [:show, :edit, :update, :destroy, :update_field]
before_filter :user_has_to_belongs_to_subject_company, :only => [:show, :edit, :update, :destroy, :update_field]

def show
  @messages = @subject.get_user_messages(current_user)
end

private

def get_subject
  @subject = Subject.find(params[:id])
end

def user_has_to_belongs_to_subject_company
  unless @current_user.company.eql?(@subject.company)
    raise "Error: current_user does not belongs to subject's company"
  end
end

这是我的规格文件：

require 'spec_helper'

describe SubjectsController do  
  describe "for signed users" do
    before(:each) do
      @current_user = Factory(:user)
      sign_in @current_user
    end

    describe "for user belonging to subject's company" do
      before(:each) do
        @subject = mock_model(Subject)  
        Subject.stub!(:find).with(@subject).and_return(@subject)
        @current_user.stub_chain(:company, :eql?).and_return(true)
        @subject.stub!(:company)
      end

      it "should not raise an exception" do
        expect { get :show, :id => @subject }.to_not raise_error
      end
    end

    describe "for user not belonging to subject's company" do
      before(:each) do
        @subject = mock_model(Subject)  
        Subject.stub!(:find).with(@subject).and_return(@subject)
        @current_user.stub_chain(:company, :eql?).and_return(false)
        @subject.stub!(:company)
      end

      it "should raise an exception" do
        expect { get :show, :id => @subject }.to raise_error
      end
    end
  end
end

最后，这是错误消息：

SubjectsController for signed users for user belonging to subject's company should not raise an exception
     Failure/Error: expect { get :show, :id => @subject }.to_not raise_error
     expected no Exception, got #<RuntimeError: Error: current_user does not belongs to subject's company>
     # ./spec/controllers/subjects_controller_spec.rb:19:in `block (4 levels) in <top (required)>'

感谢帮助！

Answer 1

我没有看到问题，但这是一个重构建议。 如果您发现自己通常使用更多的模拟和存根，也许是时候重新考虑您的界面了​​。 在这种情况下，可以使控制器更纤细，模型更胖。

# subjects_controller_spec.rb
describe "for user belonging to subject's company" do
  before(:each) do
    @subject = mock_model(Subject, :verify_user => true)  
    Subject.stub!(:find).with(@subject).and_return(@subject)
  end

# subjects_controller.b
def user_has_to_belongs_to_subject_company
  @subject.verify_user(@current_user)
end

# subject.rb
class Subject
  def verify_user(user)
    unless user.company.eql?(company)
      raise "Error: current_user does not belongs to subject's company"
    end

Answer 2

如果您删除了@current_user前面的@，会发生什么情况

def user_has_to_belongs_to_subject_company
  unless @current_user.company.eql?(@subject.company)

要得到

def user_has_to_belongs_to_subject_company
  unless current_user.company.eql?(@subject.company)

在您的规范中，执行controller.stub！（：current_user）.and_return @current_user

我认为问题是范围之一-测试中的@current_user与控制器中的@current_user不同。 确实取决于“ sign_in @current_user”的实现方式。

另外，不是引发异常，也许您的before_filter可以将用户重定向到另一页并设置flash [：error]？ before过滤器是处理这种情况的正确位置，因此它不应引发必须在其他地方进行挽救的异常（否则，它将向用户显示500页）。