如何最好地烘干此Rspec代码？

Question

我有以下Rspec代码，我认为可以将其干燥很多，尤其是check_creation_email_sent和check_rename_email_sent方法，我只是不知道该怎么做。

我尝试使用shared_examples和it_behaves_like执行此shared_examples ，但遇到了undefined method it_behaves_like...的错误undefined method it_behaves_like...所以我希望有人可以为我提供一些undefined method it_behaves_like... 。

require 'spec_helper'

describe CreateTopicFolder do
  let(:ids) { [123,456] }

  def clear_bucket(topic_id)
    subject.find_folder(topic_id).each { |obj| obj.delete } unless subject.find_folder(topic_id).nil?
  end

  def check_folder_and_object(topic_id, permalink, old_permalink=nil)
    folder = subject.find_folder(topic_id)
    folder.should_not be_empty
    folder.size.should == 1

    object = folder.first
    object.key.should include(permalink)
    object.key.should_not include(old_permalink) unless old_permalink.nil?
  end

  def check_creation_email_sent(email, permalink)
    ActionMailer::Base.deliveries.should_not be_empty

    email.subject.should match("Folder for '#{permalink}' created")
    email.body.should include("(You can reply to this e-mail to contact Engineering if something doesn't look right)")
  end

  def check_rename_email_sent(email, permalink, old_permalink)
    ActionMailer::Base.deliveries.should_not be_empty

    email.subject.should match("Folder for '#{old_permalink}' renamed to '#{permalink}'")
    email.body.should include("(You can reply to this e-mail to contact Engineering if something doesn't look right)")
  end

  before(:all) do
    ids.each { |folder| clear_bucket(folder) }
    permalink = "123-How-to-Have-Fun"
    subject.create_or_rename_folder(permalink)
  end

  it 'should find an existing folder in the S3 bucket if it exists' do
    subject.find_folder(123).should_not be_empty
  end

  it 'should create a new folder with the topic permalink as name if none already exists' do
    subject.find_folder(456).should be_nil

    permalink = "456-How-to-Not-Have-Any-Fun"
    subject.create_or_rename_folder(permalink)
    email = subject.instance_variable_get(:@email)

    check_creation_email_sent(email, permalink)
    check_folder_and_object(456, permalink)
  end

  it 'should rename an existing folder with new permalink' do
    subject.find_folder(456).should_not be_empty

    permalink = "456-How-to-Have-Fun-Again"
    old_permalink = subject.instance_variable_get(:@old_permalink)
    subject.create_or_rename_folder(permalink)
    email = subject.instance_variable_get(:@email)

    check_rename_email_sent(email, permalink, old_permalink)
    check_folder_and_object(456, permalink, old_permalink)
  end
end

在此先感谢您的帮助！

Answer 1

您可能正在寻找shared_examples_for("a thing")和it_should_behave_like("a thing") 。