一個函數中有多個IF語句-OOP

Question

我想檢查輸入的三角形是否是等腰，等於等。第一個if語句有效，但是一旦我引入了第二個三角形，它說了意外的t_else，下面是代碼...

public function typeOfTriangle()
{ 
        if ($this->sideOneLength == $this->sideTwoLength && $this->sideTwoLength == $this->baseLength) {
            echo "<h1>Equilateral Triangle</h1>";
        else if ($this->sideOneLength == $this->sideTwoLength OR $this->sideOneLength == $this->baseLength OR $this->sideTwoLength == $this->baseLength) {
            echo "<h1>Isosceles Triangle</h1>";
    }
}

有任何想法嗎？

Answer 1

您有語法錯誤：

public function typeOfTriangle()
{ 
        if ($this->sideOneLength == $this->sideTwoLength && $this->sideTwoLength == $this->baseLength) {
            echo "<h1>Equilateral Triangle</h1>";
        }else if ($this->sideOneLength == $this->sideTwoLength OR $this->sideOneLength == $this->baseLength OR $this->sideTwoLength == $this->baseLength) {
            echo "<h1>Isosceles Triangle</h1>";
        }
}

Answer 2

需要大括號}

        if ($this->sideOneLength == $this->sideTwoLength && $this->sideTwoLength == $this->baseLength) {
            echo "<h1>Equilateral Triangle</h1>";
        }
        else if ($this->sideOneLength == $this->sideTwoLength OR $this->sideOneLength == $this->baseLength OR $this->sideTwoLength == $this->baseLength) {
            echo "<h1>Isosceles Triangle</h1>";
        }

Answer 3

我建議一種稍微不同的，更易讀的方法：

public function getSides()
{
    return array($this->sideOneLength, $this->sideTwoLength, $this->sideThreeLength);
}

public function typeOfTriangle()
{
    $uniqueSides = count(array_unique($this->getSides()));

    if ($uniqueSides == 1) {
        return "Equilateral";
    } elseif ($uniqueSides == 2) {
        return "Isosceles";
    } else {
        return "Normal triangle";
    }
}

Answer 4

也許這更好？ （根據Vlad Preda的示例：

public function getSides()
{
    return array($this->sideOneLength, $this->sideTwoLength, $this->sideThreeLength);
}

public function typeOfTriangle()
{
    $uniqueSides = count(array_unique($this->getSides()));

    switch ($uniqueSides) {
      case 1:
        return "Equilateral";
        break;

      case 2:
        return "Isosceles";
        break;

      default:
        return "Normal triangle";
        break;
    }

}