重構此Java sql代碼段

Question

我想將這兩個SQL查詢合並為1，這可能嗎？ 不幸的是，我不是SQL專家。

我目前使用2個查詢的代碼段如下：

if(myFlag.equals("") || isFlagPirate.equals("N")){

    //get list of available ship id, ship name as options for the ship dropdown list
    sqlShipListString =
            "select distinct ship.ship_id, ship.name from admiralty_branch  " +
                    "left join ship on ship.ship_id=admiralty_branch.ship_id " +
                    "where admiralty_branch_id= " + admiraltyid +
                    " order by ship.name";

}else{

    if(isFlagPirate.equals("Y")){           

        //get list of available ship id, ship name as options for the ship dropdown list
        sqlShipListString =
                "select distinct ship.ship_id, ship.name from ship  " +
                        "left join ship_type on ship.ship_id=ship_type.ship_id " +
                        "left join fleet on ship_type.fleet_id=fleet.fleet_id " +
                        "where fleet_id= " + fleetId +
                        " order by ship.name";
    }
}

根據要求，表結構：

**ship**
ship_id
name

**admiralty_branch**
admiralty_branch_id
ship_id

**ship_type**
ship_id
fleet_id

**fleet**
fleet_id

Answer 1

這是一個丑陋的解決方案。 海盜的左2個連接點與非海盜的1個連接點使模式有所不同。 我不會僅對這兩個查詢進行重構。 如果您有更多內容，可以考慮創建某種sqlbuilder。

public String getSql(String isFlagPirate)
{
    if(myFlag .equals("") || isFlagPirate.equals("N")){

        //get list of available ship id, ship name as options for the ship dropdown list
        return
                buildSql("admiralty_branch  ", "ship on ship.ship_id=admiralty_branch.ship_id ", 
                        "admiralty_branch_id", admiraltyid);

    }else{

        if(isFlagPirate.equals("Y")){           

            //get list of available ship id, ship name as options for the ship dropdown list
            return buildSql("ship  ", "ship_type on ship.ship_id=ship_type.ship_id left join fleet on ship_type.fleet_id=fleet.fleet_id ",
                    "fleet_id", fleetId);
        }
        return "";
    }
}

protected String buildSql(String table, String leftjoin, String whereFieldName, String whereFieldValue)
{
    return "select distinct ship.ship_id, ship.name from "+table +
            "left join "+leftjoin +
            "where "+whereFieldName+"= " + whereFieldValue +
            " order by ship.name";
}