如何解決此細分錯誤？

Question

引起錯誤的行在旁邊注釋，我試圖從鏈接列表中刪除一個節點，然后在要刪除的節點旁邊設置“ previous->”旁邊時發生分段錯誤。

void LinkedList::removeNode(int k)
{
    Node* pre = NULL; 
    Node* curr = NULL;
    Node* temp = NULL;

    pre = head;

    curr = head->get_next();

    for(int i =1; i<=length; i++)
    {

        if (i == k)
        {
            temp = curr->get_next();
            pre->set_next(temp); // this line causes segmentation error
            if(curr == tail)
            {
                tail = pre;
            }
            delete curr;
            break;
        }
        pre = curr;
        if(curr->get_next() != NULL)
        {
            temp = curr->get_next();
            curr = temp;
        }
    }

Answer 1

看起來像您遍歷鏈表，但具有一些神秘的length迭代限制，在節點刪除代碼中未對此進行修改...

下面是一些優化的代碼：

void LinkedList::removeNode(int k)
{

    if (head == NULL)
        return;

    Node* curr = head; 
    Node* next = NULL;

    int i = 0;
    while ((next = curr->get_next()) != NULL) {
        if (++i == k) {
            curr->set_next(next->get_next());

            if (next == tail)
                tail = curr;

            next->set_next(NULL);
            delete next;
            length--;
            break;
        }

        curr = next;
    }
}