如何優化代碼以使其更快，更友好？

Question

<div id="database"> 
<form action="http://localhost/database/edit.php"  method="post">
<br>Please enter the ID of item you want to edit: <input type="text" name="ID" /><br><br>
What do you want to change:<br> <br>
<input type="radio"  name="change" value="Name"/>Name<br><br>
<input type="radio"  name="change" value="Cause" size="100" />Cause <br><br>
<input type="radio"  name="change" value="Symptom" size="200" />Symptom <br><br>
<input type="radio"  name="change" value="Gene_affected" size="200" />Gene_affected <br><br>
   Change it to: <input type="text" name="New" /><br><br>
<input type="submit" onclick="clicked(event)" />
</form>
</div> 

那就是我的databse.php

   <?php
$con = mysql_connect("localhost","root");
if (!$con)
  {
  die('Could not connect: ' . mysql_error());
  }

mysql_select_db("database", $con);

mysql_query("UPDATE pleasework SET $_POST[change] = '$_POST[New]'
WHERE ID='$_POST[ID]'");
echo "Change Successful<br>" ;
header("Location: databse.php");
mysql_close($con);
?>

那就是我的edit.php

如何使用1個查詢更改表中的所有框？ ///////////////////////////////////////////////////// ////////

<div id="database"> 
<form action="http://localhost/database/edit.php"  method="post">
<br>Please enter the ID of item you want to edit: <input type="text" name="ID" /><br><br>
What do you want to change:<br> <br>
   Change Name to: <input type="text" name="New" /><br><br>
   Change Cause to: <input type="text" name="New1" /><br><br>
   Change Symptom to: <input type="text" name="New2" /><br><br>
   Change Gene_affected to: <input type="text" name="New3" /><br><br>
<input type="submit" onclick="clicked(event)" />
</form>
</div>

這是我新的主要php文件。 我設法使它同時更新所有4個框，但它仍然如此不可靠且緩慢。 請幫助？

mysql_select_db("database", $con);

mysql_query("UPDATE pleasework SET Name= '$_POST[New]' WHERE ID='$_POST[ID]'");
mysql_query("UPDATE pleasework SET Cause= '$_POST[New1]' WHERE ID='$_POST[ID]'");
mysql_query("UPDATE pleasework SET Symptom= '$_POST[New2]' WHERE ID='$_POST[ID]'");
mysql_query("UPDATE pleasework SET Gene_affected= '$_POST[New3]' WHERE ID='$_POST[ID]'");
 echo "Change Successful<br>" ;
 header("Location: databse.php");
 mysql_close($con);

有什么建議可以幫助我改善代碼嗎？ 謝謝！

Answer 1

不建議使用mysql_函數，應考慮使用msqli_或pdo

這是使用mysqli_更新多個字段的mysqli_

$conn = $mysqli->prepare("UPDATE pleasework SET 
   field1 = ?,  
   field2 = ?  
   WHERE ID = ?");
$conn->bind_param(
   $_POST['value1'],
   $_POST['value2'],
   $_POST['id']);
$conn->execute(); 
$conn->close();

---

現在您已經知道mysql_已被棄用，這是您正在尋找的解決方案：

$sql = "UPDATE pleasework SET column_name1='value', column_name2='value' WHERE ID='$_POST[ID]'";

Answer 2

您是否考慮過使用復選框代替單選輸入？ 例如：

然后在PHP方面，您將有以下查詢：

$change_fields = array('Name', 'Cause', 'Symptom', 'Gene_affected');
$query = '';
foreach(change_fields as $field) {
    if(isset($_POST[field])) {
        $query .= ",$_POST[field] = '$_POST[New]'";
    }
}
$query = rtrim(query, ',');

if(!empty($query)) {
     mysql_query("UPDATE pleasework SET $query WHERE ID=$_POST[ID]");")
}

通常，我會使用這些值並使用某種包裝數據庫類，但這是您在對此感到滿意之后想要做的事情。