有一個分段錯誤 C++

Question

我知道我在這方面不是最好的，但我正在努力學習。 我嘗試編譯我的程序並且它可以工作。 我運行該程序，但是當我到達最后時，它說轉儲的分段錯誤。 我認為這涉及我正在嘗試進行的排序。 在我嘗試按stealsPG排序之前它起作用了。 在我這樣做並交換后，它停止工作。 任何想法為什么？

    //main.cpp

#include <string>
#include "Player.h"
#include <fstream>
#include <iostream>
#include <sstream>
#include <iomanip>
#include <stdio.h>
#include <stdlib.h>

using namespace std;

int main()
{

string response;
Player* PlaArray = new Player[5];
cout << "Time to make your basktball team!" << endl;
cout << "Press 1 to go by position and 2 if you do not care!" << endl;
cin >> response;
ofstream outFile;
outFile.open("Team.txt");
ifstream inFile;
string pick1;
string pick2;
string pick3;
string pick4;
string pick5;
string player1;
string player2;
string player3;
string player4;
string player5;
string firstname;
string lastname;
string position;
string team;
string pointsPG;
string reboundsPG;
string assistsPG;
string stealsPG;
string fake;
if (response == "1")
{
    cout << "How would you like to sort your Point Guards?" << endl;
    cout << "Press 1 if you dont have a preferance, 2 for points per game(PPG), 3 for rebounds per game(RPG)," << endl;
    cout << "Press 4 for assists per game(APG), and 5 for steals per game(SPG)." << endl;
    cin >> pick1;
    if (pick1 == "1")
    {
        for(int x = 0; x<1; x++)
        {
            inFile.open("PG.txt");
            getline(inFile, position, ',');
            getline(inFile, firstname, ',');
            getline(inFile, lastname, ',');
            getline(inFile, team, ',');
            getline(inFile, pointsPG, ',');
            getline(inFile, reboundsPG, ',');
            getline(inFile, assistsPG, ',');
            getline(inFile, stealsPG, '\n');
            PlaArray[x].setFirstname(firstname);
            PlaArray[x].setLastname(lastname);
            PlaArray[x].setPosition(position);
            PlaArray[x].setTeam(team);
            PlaArray[x].setPointsPG(pointsPG);
            PlaArray[x].setReboundsPG(reboundsPG);
            PlaArray[x].setAssistsPG(assistsPG);
            PlaArray[x].setStealsPG(stealsPG);
            if (outFile.is_open())
            {
                player1 = PlaArray[x].Report();
            }
            else
            {
                cout << "Unable to Open File" << endl;
            }

        }
        inFile.close();
    }
    cout << "How would you like to sort your Shooting Guards?" << endl;
    cout << "Press 1 if you dont have a preferance, 2 for points per game(PPG), 3 for rebounds per game(RPG)," << endl;
    cout << "Press 4 for assists per game(APG), and 5 for steals per game(SPG)." << endl;
    cin >> pick2;
    if (pick2 == "1")
        {
        for(int x = 0; x<1; x++)
        {
            inFile.open("SG.txt");  
            getline(inFile, position, ',');
            getline(inFile, firstname, ',');
            getline(inFile, lastname, ',');
            getline(inFile, team, ',');
            getline(inFile, pointsPG, ',');
            getline(inFile, reboundsPG, ',');
            getline(inFile, assistsPG, ',');
            getline(inFile, stealsPG, '\n');
            PlaArray[x].setFirstname(firstname);
            PlaArray[x].setLastname(lastname);
            PlaArray[x].setPosition(position);
            PlaArray[x].setTeam(team);
            PlaArray[x].setPointsPG(pointsPG);
            PlaArray[x].setReboundsPG(reboundsPG);
            PlaArray[x].setAssistsPG(assistsPG);
            PlaArray[x].setStealsPG(stealsPG);
            if (outFile.is_open())
                {
                    player2 = PlaArray[x].Report();
                }
            else
            {
                cout << "Unable to Open File" << endl;
            }   

            }
            }
    inFile.close();
    cout << "How would you like to sort your Small Fowards?" << endl;
    cout << "Press 1 if you dont have a preferance, 2 for points per game(PPG), 3 for rebounds per game(RPG)," << endl;
    cout << "Press 4 for assists per game(APG), and 5 for steals per game(SPG)." << endl;
    cin >> pick3;
    if (pick3 == "1")
    {
        for(int x = 0; x<1; x++)
        {
        inFile.open("SF.txt");
        getline(inFile, position, ',');
        getline(inFile, firstname, ',');
        getline(inFile, lastname, ',');
        getline(inFile, team, ',');
        getline(inFile, pointsPG, ',');
        getline(inFile, reboundsPG, ',');
        getline(inFile, assistsPG, ',');
        getline(inFile, stealsPG, '\n');
        PlaArray[x].setFirstname(firstname);
        PlaArray[x].setLastname(lastname);
        PlaArray[x].setPosition(position);
        PlaArray[x].setTeam(team);
        PlaArray[x].setPointsPG(pointsPG);
        PlaArray[x].setReboundsPG(reboundsPG);
        PlaArray[x].setAssistsPG(assistsPG);
        PlaArray[x].setStealsPG(stealsPG);
        if (outFile.is_open())
        {
            player3 = PlaArray[x].Report();
        }
        else
        {
            cout << "Unable to Open File" << endl;
        }

        }
        inFile.close();
    }
    cout << "How would you like to sort your Power Fowards?" << endl;
    cout << "Press 1 if you dont have a preferance, 2 for points per game(PPG), 3 for rebounds per game(RPG)," << endl;
    cout << "Press 4 for assists per game(APG), and 5 for steals per game(SPG)." << endl;
    cin >> pick4;
    if (pick4 == "1")
    {
        for(int x = 0; x<1; x++)
        {
        inFile.open("PF.txt");
        getline(inFile, position, ',');
        getline(inFile, firstname, ',');
        getline(inFile, lastname, ',');
        getline(inFile, team, ',');
        getline(inFile, pointsPG, ',');
        getline(inFile, reboundsPG, ',');
        getline(inFile, assistsPG, ',');
        getline(inFile, stealsPG, '\n');
        PlaArray[x].setFirstname(firstname);
        PlaArray[x].setLastname(lastname);
        PlaArray[x].setPosition(position);
        PlaArray[x].setTeam(team);
        PlaArray[x].setPointsPG(pointsPG);
        PlaArray[x].setReboundsPG(reboundsPG);
        PlaArray[x].setAssistsPG(assistsPG);
        PlaArray[x].setStealsPG(stealsPG);
        if (outFile.is_open())
        {
            player4 = PlaArray[x].Report();
        }
        else
        {
            cout << "Unable to Open File" << endl;
        }

        }
        inFile.close();
    }
    cout << "How would you like to sort your Cetners Guards?" << endl;
    cout << "Press 1 if you dont have a preferance, 2 for points per game(PPG), 3 for rebounds per game(RPG)," << endl;
    cout << "Press 4 for assists per game(APG), and 5 for steals per game(SPG)." << endl;
    cin >> pick5;
    if (pick5 == "1")
    {
        for(int x = 0; x<1; x++)
        {
            inFile.open("C.txt");
            getline(inFile, position, ',');
            getline(inFile, firstname, ',');
            getline(inFile, lastname, ',');
            getline(inFile, team, ',');
            getline(inFile, pointsPG, ',');
            getline(inFile, reboundsPG, ',');
            getline(inFile, assistsPG, ',');
            getline(inFile, stealsPG, '\n');
            PlaArray[x].setFirstname(firstname);
            PlaArray[x].setLastname(lastname);
            PlaArray[x].setPosition(position);
            PlaArray[x].setTeam(team);
            PlaArray[x].setPointsPG(pointsPG);
            PlaArray[x].setReboundsPG(reboundsPG);
            PlaArray[x].setAssistsPG(assistsPG);
            PlaArray[x].setStealsPG(stealsPG);
    if (outFile.is_open())
    {
        player5 = PlaArray[x].Report();
    }
    else
    {
        cout << "Unable to Open File" << endl;
    }

    }
    inFile.close();
    }
if (pick5 == "5");
{
    for( int x = 0; x<10; x++)
    {
        inFile.open("C.txt");
        getline(inFile, position, ',');
            getline(inFile, firstname, ',');
            getline(inFile, lastname, ',');
            getline(inFile, team, ',');
            getline(inFile, pointsPG, ',');
            getline(inFile, reboundsPG, ',');
            getline(inFile, assistsPG, ',');
            getline(inFile, stealsPG, '\n');
            PlaArray[x].setFirstname(firstname);
            PlaArray[x].setLastname(lastname);
            PlaArray[x].setPosition(position);
            PlaArray[x].setTeam(team);
            PlaArray[x].setPointsPG(pointsPG);
            PlaArray[x].setReboundsPG(reboundsPG);
            PlaArray[x].setAssistsPG(assistsPG);
            PlaArray[x].setStealsPG(stealsPG);
    int i;
    int j;
    for (i = 0; i<9; i++)
    {
        for (j = 0; j<9; j++)
        {
            if  (PlaArray[j].getStealsPG().compare(PlaArray[j+1].getStealsPG()) >0)
            {
                swap(PlaArray[j], PlaArray[j+1]);
            }
        }
    }
    }
        for(int x = 0; x<1; x++)
        {
            getline(inFile, position, ',');
            getline(inFile, firstname, ',');
            getline(inFile, lastname, ',');
            getline(inFile, team, ',');
            getline(inFile, pointsPG, ',');
            getline(inFile, reboundsPG, ',');
            getline(inFile, assistsPG, ',');
            getline(inFile, stealsPG, '\n');
            PlaArray[x].setFirstname(firstname);
            PlaArray[x].setLastname(lastname);
            PlaArray[x].setPosition(position);
            PlaArray[x].setTeam(team);
            PlaArray[x].setPointsPG(pointsPG);
            PlaArray[x].setReboundsPG(reboundsPG);
            PlaArray[x].setAssistsPG(assistsPG);
            PlaArray[x].setStealsPG(stealsPG);
        if (outFile.is_open())
                {
                        player5 = PlaArray[x].Report();
                }
                else
                {
                        cout << "Unable to Open File" << endl;
                }
        }   
    inFile.close();


}
outFile.close();

    cout << player1 << endl;
    cout << player2 << endl;
    cout << player3 << endl;
    cout << player4 << endl;
    cout << player5 << endl;
}
}
void swap(int*i, int*j)
{
    int c;
    c = *i;
    *i = *j;
    *j = c;
}               

Answer 1

我不確定這是唯一的問題，但這是一個（大！）問題。

您為 5 位Player分配空間

Player* PlaArray = new Player[5];

但是你嘗試使用其中的 10 個

if (pick5 == "5");
{
    for( int x = 0; x<10; x++)
    {
        inFile.open("C.txt");
        getline(inFile, position, ',');
        getline(inFile, firstname, ',');
        getline(inFile, lastname, ',');
        getline(inFile, team, ',');
        getline(inFile, pointsPG, ',');
        getline(inFile, reboundsPG, ',');
        getline(inFile, assistsPG, ',');
        getline(inFile, stealsPG, '\n');
        PlaArray[x].setFirstname(firstname);
        PlaArray[x].setLastname(lastname);
        PlaArray[x].setPosition(position);

這不好。

ps：而且，是的：tobi303 是對的：你的格式很糟糕。 我們是在開玩笑，但建議是一個很好的建議：正確格式化您的代碼。

pps：對不起，我的英語不好。