堆棧內存溢出
  簡體   English   中英

將觸發器的一部分提取到存儲過程中后出現死鎖

[英]Deadlocks after extracting part of the trigger into a stored procedure

 原文  2016-10-03 17:30:33  5   1    sql/ sql-server/ tsql/ deadlock/ database-deadlocks

問題描述

今天，我們有一個非常有趣的案例，這使我感到非常困惑。 簡而言之，我們進行了一些重構，從重復的代碼中清除觸發器，將其提取到單個可重用的存儲過程中。 我們認為這種重構不會有副作用，但是我們犯了嚴重錯誤。 發布后，我們遇到了很多死鎖和性能下降，沒有明顯的原因。 在檢查了系統表以查看使用了什么DB后，我們發現涉及上面的重構，最后我們回滾了更新。

我們尚未在測試環境中重現該問題以探索解決方法，因此發生了一些棘手的情況以使問題可見。

以下是有關更改內容的詳細信息。 我們更新了許多觸發器，但它們都非常相似，我將向您展示。 這已經足夠了，因為我發現了一個死鎖圖，該圖表明存在一個死鎖，其中兩個進程正在執行單個觸發器（如下所示）並死鎖。

讓我從以前起作用的解決方案開始（我們回滾到該解決方案，並且看起來也與下面顯示的死鎖解決方案相同）。 

CREATE TRIGGER [dbo].[TR__xyz__update_sync_publishers]
ON [dbo].[xyz]
AFTER INSERT, DELETE, UPDATE
AS 
BEGIN
    SET NOCOUNT ON;

    if(TRIGGER_NESTLEVEL() = 1)
    BEGIN
        create table #AffectedIDs (advisor_id int primary key)

        insert into #AffectedIDs
            select distinct t.id
            from
                (select id 
                 from inserted
                 inner join xyz a ON a.id = id
                 where [text] <> ''
                 union 
                 select id 
                 from inserted
                 inner join xyz a ON a.id = id
                 where [text] <> '') t

        declare @date datetime = getutcdate()
        declare @RegisteredObjectTypeID int = 2
        declare @SyncPublisherSourceID int = 1

        update pub
        set pub.master_update_date = @date
        from #AffectedIDs affected
        inner join sync_publishers pub on 
            pub.sync_registered_object_type_id = @RegisteredObjectTypeID 
            and pub.sync_publisher_source_id = @SyncPublisherSourceID
            and pub.sync_object_id = affected.advisor_id

        insert into sync_publishers (sync_object_id, sync_registered_object_type_id, sync_publisher_source_id , master_update_date)
        select 
            affected.advisor_id,
            @RegisteredObjectTypeID,
            @SyncPublisherSourceID,
            @date
        from #AffectedIDs affected
        left join sync_publishers pub on 
            pub.sync_registered_object_type_id = @RegisteredObjectTypeID
            and pub.sync_publisher_source_id = @SyncPublisherSourceID
            and pub.sync_object_id = affected.advisor_id
        where 
            pub.sync_object_id is null

        drop table #AffectedIDs
    END
END

這是陷入僵局的新觸發器。 

CREATE TRIGGER [dbo].[TR__xyz__update_sync_publishers]
   ON [dbo].[xyz]
   AFTER INSERT,DELETE,UPDATE
AS 
BEGIN

    SET NOCOUNT ON;

    declare @ids dtInt

    insert into @ids
    select distinct t.id
    from
    (
        select id from inserted
        INNER JOIN xyz a ON a.id = id
        WHERE [text] <> ''
        union 
        select id from inserted
        INNER JOIN xyz a ON a.id = id
        WHERE [text] <> ''
    ) t

    exec SyncTracker_PublishEvent 2, @ids

END

這是提取的SP的定義： 

CREATE PROCEDURE [dbo].[SyncTracker_PublishEvent]
    @objectTypeId int, 
    @ids dtInt readonly
AS
BEGIN
    SET NOCOUNT ON;

    if(TRIGGER_NESTLEVEL() > 1) RETURN;

    declare @pubSourceId int = 1
    declare @date datetime = getutcdate()

    update pub
    set pub.master_update_date = @date
    from @ids affected
    inner join sync_publishers pub
    on pub.sync_registered_object_type_id = @objectTypeId 
        and pub.sync_publisher_source_id = @pubSourceId
        and pub.sync_object_id = affected.value

    insert into sync_publishers (sync_object_id, sync_registered_object_type_id, sync_publisher_source_id , master_update_date)
    select affected.value, @objectTypeId, @pubSourceId, @date
    from @ids affected
    left join sync_publishers pub
    on pub.sync_registered_object_type_id = @objectTypeId
        and pub.sync_publisher_source_id = @pubSourceId
        and pub.sync_object_id = affected.value
    where 
        pub.sync_object_id is null
END
GO

dtInt的定義。 

CREATE TYPE [dbo].[dtInt] AS TABLE
(
    [value] [int] NOT NULL,
    PRIMARY KEY CLUSTERED 
    (
        [value] ASC
    )
)

最后是死鎖圖。 

<deadlock>
  <victim-list>
    <victimProcess id="processe1892fe8c8" />
  </victim-list>
  <process-list>
    <process id="processe1892fe8c8" taskpriority="0" logused="3824" waitresource="KEY: 5:72057602924150784 (4776e78e2961)" waittime="5686" ownerId="2583257965" transactionname="user_transaction" lasttranstarted="2016-10-03T08:30:42.500" XDES="0xe192b24408" lockMode="U" schedulerid="6" kpid="41296" status="suspended" spid="141" sbid="0" ecid="0" priority="0" trancount="2" lastbatchstarted="2016-10-03T08:30:42.503" lastbatchcompleted="2016-10-03T08:30:42.493" lastattention="2016-10-03T08:29:01.693" clientapp="..." hostname="..." hostpid="22572" loginname="kbuser" isolationlevel="read committed (2)" xactid="2583257965" currentdb="5" lockTimeout="4294967295" clientoption1="673316896" clientoption2="128056">
      <executionStack>
        <frame procname="63c1b4d8-1c55-4429-b057-81fb6da8f780.dbo.SyncTracker_PublishEvent" line="21" stmtstart="1178" stmtend="1680" sqlhandle="0x030005007bf23c4b5012b40092a6000001000000000000000000000000000000000000000000000000000000">
update pub
    set pub.master_update_date = @date
    from @ids affected
    inner join sync_publishers pub
    on pub.sync_registered_object_type_id = @objectTypeId 
        and pub.sync_publisher_source_id = @pubSourceId
        and pub.sync_object_id = affected.valu    </frame>
        <frame procname="63c1b4d8-1c55-4429-b057-81fb6da8f780.dbo.TR__xyz__update_sync_publishers" line="28" stmtstart="1300" stmtend="1372" sqlhandle="0x03000500f711233ddee4c60090a6000000000000000000000000000000000000000000000000000000000000">
exec SyncTracker_PublishEvent 2, @id    </frame>
        <frame procname="unknown" line="1" stmtstart="1054" stmtend="3032" sqlhandle="0x02000000912653235c5ef3529289f19ae4445e62ee1ccbc00000000000000000000000000000000000000000">
unknown    </frame>
        <frame procname="unknown" line="1" sqlhandle="0x0000000000000000000000000000000000000000000000000000000000000000000000000000000000000000">
unknown    </frame>
      </executionStack>
    </process>
    <process id="processdfa401b848" taskpriority="0" logused="9384" waitresource="KEY: 5:72057602924150784 (1501093f83b4)" waittime="5814" ownerId="2582414029" transactionname="user_transaction" lasttranstarted="2016-10-03T08:30:09.933" XDES="0x104486ac408" lockMode="U" schedulerid="1" kpid="19548" status="suspended" spid="213" sbid="0" ecid="0" priority="0" trancount="2" lastbatchstarted="2016-10-03T08:30:53.047" lastbatchcompleted="2016-10-03T08:30:53.047" lastattention="1900-01-01T00:00:00.047" clientapp="..." hostname="..." hostpid="6196" loginname="kbuser" isolationlevel="read committed (2)" xactid="2582414029" currentdb="5" lockTimeout="4294967295" clientoption1="673316896" clientoption2="128056">
      <executionStack>
        <frame procname="63c1b4d8-1c55-4429-b057-81fb6da8f780.dbo.SyncTracker_PublishEvent" line="21" stmtstart="1178" stmtend="1680" sqlhandle="0x030005007bf23c4b5012b40092a6000001000000000000000000000000000000000000000000000000000000">
update pub
    set pub.master_update_date = @date
    from @ids affected
    inner join sync_publishers pub
    on pub.sync_registered_object_type_id = @objectTypeId 
        and pub.sync_publisher_source_id = @pubSourceId
        and pub.sync_object_id = affected.valu    </frame>
        <frame procname="63c1b4d8-1c55-4429-b057-81fb6da8f780.dbo.TR__xyz__update_sync_publishers" line="28" stmtstart="1300" stmtend="1372" sqlhandle="0x03000500f711233ddee4c60090a6000000000000000000000000000000000000000000000000000000000000">
exec SyncTracker_PublishEvent 2, @id    </frame>
        <frame procname="unknown" line="1" stmtstart="1120" stmtend="3132" sqlhandle="0x020000007414d821ed68a2ab4462b4eca6b2fdb4ba28cc350000000000000000000000000000000000000000">
unknown    </frame>
        <frame procname="unknown" line="1" sqlhandle="0x0000000000000000000000000000000000000000000000000000000000000000000000000000000000000000">
unknown    </frame>
      </executionStack>
    </process>
  </process-list>
  <resource-list>
    <keylock hobtid="72057602924150784" dbid="5" objectname="63c1b4d8-1c55-4429-b057-81fb6da8f780.dbo.sync_publishers" indexname="IX__sync_publishers__registered_object_type_id__sync_object_id" id="lock10887a96b00" mode="X" associatedObjectId="72057602924150784">
      <owner-list>
        <owner id="processdfa401b848" mode="X" />
      </owner-list>
      <waiter-list>
        <waiter id="processe1892fe8c8" mode="U" requestType="wait" />
      </waiter-list>
    </keylock>
    <keylock hobtid="72057602924150784" dbid="5" objectname="63c1b4d8-1c55-4429-b057-81fb6da8f780.dbo.sync_publishers" indexname="IX__sync_publishers__registered_object_type_id__sync_object_id" id="lockdb7d7b8200" mode="X" associatedObjectId="72057602924150784">
      <owner-list>
        <owner id="processe1892fe8c8" mode="X" />
      </owner-list>
      <waiter-list>
        <waiter id="processdfa401b848" mode="U" requestType="wait" />
      </waiter-list>
    </keylock>
  </resource-list>
</deadlock>

死鎖圖

sync_publishers的定義在此處提供： http ://pastebin.com/LviwwCDi。

如果您對可行的原因有任何想法-歡迎與我們分享-我們將非常感謝！

UPDATE 1. UPDATE / INSERT到sync_publishers中的實際執行計划

實際的執行計划看起來幾乎相同。

新的執行計划（有時會陷入僵局）。 新

舊的執行計划（沒有）。 舊

更新2。嘗試了一些建議

我今天確實嘗試了一些建議：

  1. 由於完全沒有刪除列的非聚集索引中的sync_publisher_source_id ，因此在查詢計划中擺脫了“關鍵查找”的問題-這在我們的實現中並不是真正必須的。

  2. 將UPDATE + INSERT重寫為單個MERGE語句。 

     MERGE sync_publishers2 t USING @ids s ON s.[value] = t.sync_object_id and t.sync_registered_object_type_id = @objectTypeId WHEN MATCHED THEN UPDATE SET master_update_date = @date WHEN NOT MATCHED THEN INSERT (sync_object_id, sync_registered_object_type_id, master_update_date) VALUES (s.[value], @objectTypeId, @date);

開始在MERGE語句上陷入僵局。 可以在這里查看新的死鎖圖： http : //pastebin.com/QNJk7tea 。

更新3。嘗試合並提示

我嘗試使用xlock和holdlock提示進行MERGE ，盡管運氣不好，但再次使MERGE陷入了僵局。 

MERGE sync_publishers2 with(xlock, holdlock) t

1 個解決方案

解決方案1
 0  2017-01-04 07:07:39

在並行3個工作負載會話1小時以上之后，該版本似乎沒有死鎖。 我不能真正首先發現死鎖的確切原因，但是我能做的是強調死鎖嘗試也帶來了MERGE語句的差異：波紋管版本（似乎正常）使用CTE允許MERGE的ON表達式將以僅提及PK列（ sync_publisher_id ）的方式進行重寫。 

CREATE PROCEDURE [dbo].[SyncTracker_PublishEvent2]
    @objectTypeId int, 
    @ids dtInt readonly
AS
BEGIN
    SET NOCOUNT ON;

    -- stop recoursive propogations
    if(TRIGGER_NESTLEVEL() > 1) RETURN;

    declare @date datetime = getutcdate()

    ;WITH sync_publishers2CTE AS
    (
        SELECT [sync_publisher_id],
                [sync_object_id],
                [sync_registered_object_type_id],
                [master_update_date]
            FROM [dbo].[sync_publishers2] 
            WHERE sync_registered_object_type_id = @objectTypeId
    )
    MERGE sync_publishers2CTE WITH (XLOCK) trg
    USING 
    (
            SELECT sp.sync_publisher_id,
                    s.Value AS sync_object_id,
                    @objectTypeId AS sync_registered_object_type_id,
                    @date AS master_update_date
                FROM @ids s 
                LEFT JOIN sync_publishers2 sp ON sp.sync_object_id = s.Value
                                                AND sp.sync_registered_object_type_id = @objectTypeId 
    ) src
    ON (trg.sync_publisher_id = src.sync_publisher_id)
    WHEN MATCHED
        THEN UPDATE
            SET trg.master_update_date = src.master_update_date
    WHEN NOT MATCHED
        THEN INSERT
                 (sync_object_id, sync_registered_object_type_id, master_update_date)
            VALUES
                 (sync_object_id, sync_registered_object_type_id, master_update_date);
END

示例執行計划：

執行計划

暫無
暫無

聲明:本站的技術帖子網頁，遵循CC BY-SA 4.0協議，如果您需要轉載，請注明本站網址或者原文地址。任何問題請咨詢:yoyou2525@163.com.

相關問題 在SQL存儲過程中提取字符串的某些部分 存儲過程和觸發器 MariaDB中的觸發器和存儲過程 在觸發器中執行存儲過程 觸發或存儲過程 觸發器將不執行存儲過程 用存儲過程替換觸發器 在Entity Framework 1.0中的SaveChanges之后觸發存儲過程 在數據庫上創建用戶之后，立即通過觸發器執行存儲過程 哪個更快？ 插入或直接存儲過程后觸發
相關標簽
 
粵ICP備18138465號  © 2020-2024 STACKOOM.COM