在MySQL中使用NodeJS Promises

Question

我正在嘗試對庫（研究項目）中的Node腳本進行反向工程以按順序執行以下任務：

1）打開並讀取文件（例如，“ input.txt”）。 為簡單起見，假設內容格式正確（SQL查詢）

2）創建與MySQL數據庫的連接

3）執行查詢（由（1）構造-假設查詢已在文件中正確定義）

4）終止與數據庫的連接

我希望這些任務按順序執行（即1--4）。 我沒有使用Promises（Bluebird）的豐富經驗。 這是我到目前為止的代碼摘錄：

//Read the input file
function readFilePromise(){
    return new Promise(function(resolve, reject){
        var filePath = path.join(__dirname, filename);
        //asynchronous read
        fs.readFile(filePath, 'utf8', function (err, text){
            if (err)
                reject(err);
            else
                resolve(text.split('\n'));
        });
    })
}

//create connection
function createConnectionPromise(){
    return new Promise(function (resolve, reject){
        var connection = mysql.createConnection(connectionOptions);//global
        connection.connect(function(err){
            if(err){
                console.log('Error connecting to Db');
                reject(err);
            }
            else{
                console.log('Connection established');
                resolve(connection);
            }
        });
    })
}

//do transactions
function doTransactionsPromise (data){
    return new Promise(function (resolve, reject){
        var connection = data[0];
        var lines      = data[1];
        var topPromises = [];

        lines.forEach(function(sSQL){
            var p = new Promise(function(resolve,reject){
                console.log('Add: ' + sSQL);
                makeTransaction(connection, sSQL);
                return connection;
            });
            topPromises.push(p);
        });
        resolve(topPromises);
    });
}

//make transaction    
function makeTransaction(connection, sSQL){
  connection.beginTransaction(function(err){
        function treatErro(err, connection) {
            console.log('Failed to insert data in the database . Undoing!');
            connection.rollback();
        }

    function final() {
        connection.commit(function(err) {
            if(err) {
                treatErro(err, connection);
            }
            else {
                console.log('Added: ' + sSQL);
                return connection;
            }
        });
    }

    if(err) {
        treatErro(err, connection);
    }
    else {
        connection.query(sSQL, function (err, result) {
            if(err) {
                console.log(sSQL);
                treatErro(err, connection);
            }
            else {
                id = result.insertId;
            }
        });
        final();
    }
  });
}

Promise.all([createConnectionPromise(), readFilePromise()])
   .then(doTransactionsPromise)
   .then(function(promises){
       Promise.all(promises)
           .then(function(data){
                var connection = data[0];
                connection.end();
            });
   })
   .catch(function(error) {
       console.log('Error occurred!', error);
   });

查詢執行得很好，但與數據庫的連接不會終止。 任何幫助表示贊賞。

PS：我相信代碼可以得到很大的改進。

Answer 1

我在您的代碼中看到的可能問題是在doTransaction函數中

 function doTransactionsPromise (data){
   return new Promise(function (resolve, reject){
    var connection = data[0];
    var lines      = data[1];
    var topPromises = [];

    lines.forEach(function(sSQL){
        var p = new Promise(function(resolve,reject){
            console.log('Add: ' + sSQL);

            makeTransaction(connection, sSQL);
            return connection;
        });
        // P is never fullfilled.
        //Either transfer the responsibility to full-fill the promise to makeTransaction 
       // or makeTransaction function should return the promise which is full-filled by itself. 

        topPromises.push(p);
    });

    resolve(topPromises);
});
}

Answer 2

我沒有測試代碼，但是下面的代碼應該可以

    //Read the input file
    function readFilePromise(){
        return new Promise(function(resolve, reject){
            var filePath = path.join(__dirname, filename);
            //asynchronous read
            fs.readFile(filePath, 'utf8', function (err, text){
                if (err)
                    reject(err);
                else
                    resolve(text.split('\n'));
            });
        })
    }

    //create connection
    function createConnectionPromise(){
        return new Promise(function (resolve, reject){
            var connection = mysql.createConnection(connectionOptions);//global
            connection.connect(function(err){
                if(err){
                    console.log('Error connecting to Db');
                    reject(err);
                }
                else{
                    console.log('Connection established');
                    resolve(connection);
                }
            });
        })
    }

    //do transactions
    function doTransactionsPromise (data){



        var connection = data[0];
        var lines = data[1];
        var topPromises = [];

        topPromise = lines.map(function(sSQL){

            return makeTransaction(connection, sSQL);
        });

        return Promise.all(topPromises).then( function(){
              return connection;
        },function(){
            return connection;
        });


    }

    //make transaction    
    function makeTransaction(connection, sSQL){
      return new Promise(resolve, reject, function(){
          connection.beginTransaction(function(err){

            function treatErro(err, connection) {
                console.log('Failed to insert data in the database . Undoing!');
                connection.rollback();
                reject(connection);

            }

            function final() {
                connection.commit(function(err) {
                    if(err) {
                        treatErro(err, connection);
                    }
                    else {
                        console.log('Added: ' + sSQL);
                        resolve(connection);
                        return connection;
                    }
                });
            }

            if(err) {
                treatErro(err, connection);
            }
            else {
                connection.query(sSQL, function (err, result) {
                    if(err) {
                        console.log(sSQL);
                        treatErro(err, connection);
                    }
                    else {
                        id = result.insertId;
                    }
                });
                final();
            }
          });

      })  

    }

    Promise.all([createConnectionPromise(), readFilePromise()])
       .then(doTransactionsPromise)
       .then(function(connection){
            return connection.end();
       })
       .catch(function(error) {
           console.log('Error occurred!', error);
       });