需要幫助找出我的代碼中的錯誤

Question

所以我需要幫助弄清楚為什么我的代碼在原始印刷行上不包括數字2並包括數字99。 我是否需要更改find​​Prime（）上的內容？ 我嘗試使用索引，但情況變得更糟。

    class Sieve {
    private int max;
    private boolean[] numbers;

    public Sieve(int max) {
        if (max < 2) {
            throw new IllegalArgumentException();
        }

        this.max = max;
        numbers = new boolean[max];
        numbers[0] = false;
        numbers[1] = false;
        numbers[2] = true;
        for (int i = 2; i < max-1; i++) {
        numbers[i] = true;

        }
    }
    public void findPrimes() {
        for (int num = 2; num < max-1; num++) {
            int multiples = num + num;
            while (multiples < max-1) {
                numbers[multiples-1] = false;
                multiples += num;
            }
        }
    }
    @Override
    public String toString() {
        StringBuilder builder = new StringBuilder();
        for (int num = 2; num < max; num++) {
            if (numbers[num]) {
                builder.append(num+1).append(" ");
            }
        }
        return builder.toString();
        }
    }

class Driver
{

//  MAIN. Find some primes.

  public static void main(String [] args)
  {
    Sieve sieve = null;  //  We must initialize SIEVE or Java will cry.

//  5 points. This must print "Sieve size must be at least 2." but without the
//  quotes.

    try
    {
      sieve = new Sieve(0);
    }
    catch (IllegalArgumentException oops)
    {
      System.out.println("Sieve size must be at least 2.");
    }

//  5 points. This must print nothing.

    try
    {
      sieve = new Sieve(100);
    }
    catch (IllegalArgumentException oops)
    {
      System.out.println("Sieve size must be at least 2.");
    }

//  10 points. This must print integers from 2 to 99, separated by blanks.

    System.out.println(sieve);

//  10 points. This must print the prime numbers between 2 and 99, separated by
//  blanks. They are:
//
//  2 3 5 7 11 13 17 19 23 29 31 37 41 43 47 53 59 61 67 71 73 79 83 89 97

    sieve.findPrimes();
    System.out.println(sieve);
  }
}

它正在顯示此內容，而不是在程序的開頭沒有數字2，而在最后一行沒有數字99。

Sieve size must be at least 2.
3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 
3 5 7 11 13 17 19 23 29 31 37 41 43 47 53 59 61 67 71 73 79 83 89 97 99

Answer 1

您的toString()方法從num = 2（將num + 1附加到輸出）開始循環。 您的循環應從1開始。

public String toString() {
    StringBuilder builder = new StringBuilder();
    for (int num = 1; num < max; num++) { . // used to start at 2
        if (numbers[num]) {
            builder.append(num+1).append(" ");
        }
    }
    return builder.toString();
    }
}

另外，您的代碼設置了numbers[1] = false 。 那應該是numbers[1] = true 。

您還將循環播放，直到< max - 1 。 考慮循環直到< max 。

Answer 2

我對您的代碼進行了一些更改，需要指出的主要問題是您不需要max。 您的findPrimes（）看起來不錯，但很難閱讀且很難驗證其正確性。 您的toString（）方法應該遍歷每個元素，如果該元素為true，則將其添加到列表中。

另外1不是質數，因此numbers[1] = false; 是應該的。 為什么1不是質數？

class Sieve {
    // private int max; // max is superfluous use numbers.length instead
    private boolean[] numbers;

    public Sieve(int max) {
        if (max < 2) {
            throw new IllegalArgumentException();
        }

        numbers = new boolean[max];
        numbers[0] = false;
        numbers[1] = false;
        numbers[2] = true;
        for (int i = 2; i <numbers.length; i++) {
            numbers[i] = true;
        }
    }
    public void findPrimes() {
        // a bit more compact and neater in my opinion
        for (int num=2; num<numbers.length; num++) {
            for (int multiple=num+num; multiple<numbers.length; multiple+=num) {
                numbers[multiple] = false;
            }
        }
    }
    @Override
    public String toString() {
        StringBuilder builder = new StringBuilder();
        // you should be iterating from 0 to 99
        for (int i=0; i<numbers.length; i++) {
            if (numbers[i]) {
                builder.append(i).append(" ");
            }
        }
        return builder.toString();
    }
}

class Driver
{
    //  MAIN. Find some primes.
    public static void main(String [] args)
    {
        Sieve sieve = null;  //  We must initialize SIEVE or Java will cry.

        //  5 points. This must print "Sieve size must be at least 2." but without the
        //  quotes.

        try
        {
            sieve = new Sieve(0);
        }
        catch (IllegalArgumentException oops)
        {
            System.out.println("Sieve size must be at least 2.");
        }

        //  5 points. This must print nothing.

        try
        {
            sieve = new Sieve(100);
        }
        catch (IllegalArgumentException oops)
        {
            System.out.println("Sieve size must be at least 2.");
        }

        //  10 points. This must print integers from 2 to 99, separated by blanks.

        System.out.println(sieve);

        //  10 points. This must print the prime numbers between 2 and 99, separated by
        //  blanks. They are:
        //
        //  2 3 5 7 11 13 17 19 23 29 31 37 41 43 47 53 59 61 67 71 73 79 83 89 97

        sieve.findPrimes();
        System.out.println(sieve);
    }
}