[英]Simplifying triple nested loop to avoid callback hell in android retrofit2 (via RxJava2?)
使用android retrofit2,需要訪問深層嵌套的name
字符串以獲取並顯示其Details
(其中Detail
的對象引用了用於獲取Detail
的Group
和User
對象)。
JSON
由一個Group
列表組成,每個Group
包含一個User
列表,每個User
包含一個name
String
列表,這些name
在以下模型中捕獲:
public class Group {
@SerializedName("id")
public String id;
@SerializedName("users")
public List<User> users;
}
public class User {
@SerializedName("id")
public String id;
@SerializedName("detailNames")
public List<String> detailNames;
}
public class Detail {
// allow access to objects used to get detail
public Group group;
public User user;
@SerializedName("name")
public String name;
@SerializedName("description")
public String description;
}
使用UserApi
填充模型:
public interface UserApi {
@GET("groups")
Call<List<Group>> getGroups();
@GET("groups/{group_id}/users/{user_id}/details/{detail_name}")
Call<Detail> getDetail(
@Path("group_id") String groupId,
@Path("user_id") String userId,
@Path("detail_name") String detailName
);
}
目的是使用給定的UserApi
發出和解析請求以顯示以下格式的Dialog
:
Group1 (expandable heading)
User1 (expandable heading)
Detail1 (checkbox)
Detail2 (checkbox)
...
Group2 (expandable heading)
User2 (expandable heading)
Detail1 (checkbox)
...
...
...
問題是當前解決方案請求Group
並使用三重嵌套的for
循環訪問和獲取每個name
Detail
:
private void fetchDetails(List<Group> groupList) {
ArrayList<Group> groups = (ArrayList<Group>) groupList;
if (groups != null && groups.size() > 0) {
for (Group group : groups) {
for (User user: group.users) {
for (String detailName : user.detailNames) {
fetchDetail(group, user, detailName);
}
}
}
}
}
由於三重循環為每個name
發出請求,並且在getGroups
onResponse
回調中完成,因此問題變得更加嚴重,這似乎onResponse
/無法維護:
protected void onCreate(Bundle savedInstanceState) {
super.onCreate(savedInstanceState);
setContentView(R.layout.activity_main);
mUserApi = UserApiClient.getApi();
fetchGroups();
}
private void fetchGroups() {
Callback<List<Group>> groupsCall = new Callback<List<Group>>() {
@Override
public void onResponse(Call<List<Group>> call, Response<List<Group>> response) {
int statusCode = response.code();
switch (statusCode) {
case HttpURLConnection.HTTP_OK:
List<Group> groups = response.body();
fetchDetails(groups);
break;
}
}
@Override
public void onFailure(Call<List<Group>> call, Throwable t) {}
};
mUserApi.getGroups().enqueue(groupsCall);
}
private void fetchDetail(final Group group, final User user, String detailName) {
Callback<Detail> detailCallback= new Callback<Detail>() {
@Override
public void onResponse(Call<Detail> call, Response<Detail> response) {
int statusCode = response.code();
switch (statusCode) {
case HttpURLConnection.HTTP_OK:
MainActivity.this.runOnUiThread(new Runnable() {
@Override
public void run() {
// display details in ListView
}
});
break;
}
}
@Override
public void onFailure(Call<Detail> call, Throwable t) {}
};
mUserApi.getDetail(group.id, user.id, detailName).enqueue(detailCallback);
}
建議使用RxJava2解決方案來避免像上述實現那樣嵌套回調,但由於在管理3層嵌套訪問names
方面存在困惑,因此未完成:
Observable<List<Group>> groupCall = mUserApi.getGroups();
groupCall.flatMapIterable(x -> x)
.flatMap(group -> {
Observable.fromIterable(group.users)
.flatMap(user -> {
Observable.fromIterable(user.detailNames)
.map(detailName -> {
mUserApi.getDetail(group.id, user.id, detailName)
.flatMap(detail -> {
detail.group = group;
detail.user = user;
return Observable.just(detail)
})
.subscribeOn(Schedulers.io())
.observeOn(AndroidSchedulers.mainThread())
.subscribe(new Observer<List<Group>>() {
@Override
public void onSubscribe(Disposable d) {}
@Override
public void onNext(List<Detail> value) {
mDetails = (ArrayList<Detail>) value;
}
@Override
public void onError(Throwable e) {}
@Override
public void onComplete() {}
});
});
}
})
存在一些問題(例如, 帶有條件的RxJava多循環 )可以處理RxJava中的嵌套,但仍不確定如何將其應用於深度嵌套的name
s。
是否可以使用RxJava2避免回調地獄並簡化三重for
循環,還有其他方法,還是該解決方案應訴諸AsyncTask
/ AsyncTaskLoader
同步請求?
正如我在評論中提到的那樣,我認為您已經擁有的幾乎是最簡單的表格。 但是似乎您有興趣在沒有循環的情況下執行此操作,因此這里有一些建議(但不一定更好):
方法1:容器類
如果您願意創建可以在單個對象中容納組,用戶,詳細信息名稱的中間容器類,則可以執行以下操作:
首先,創建以下容器類:
public class UserWithGroup {
final Group group;
final User user;
public UserWithGroup(Group group, User user) {
this.group = group;
this.user = user;
}
}
public class DetailWithUser {
final Group group;
final User user;
final String detailName;
public DetailWithUser(Group group, User user, String detailName) {
this.group = group;
this.user = user;
this.detailName = detailName;
}
}
然后,使用Java 8 Stream的代碼可以是:
private void fetchDetails(List<Group> groupList) {
groupList.stream()
.flatMap(g -> g.users.stream().map(u -> new UserWithGroup(g, u)))
.flatMap(ug -> ug.user.detailNames.stream().map(n -> new DetailWithUser(ug.group, ug.user, n)))
.forEach(d -> fetchDetail(d.group, d.user, d.detailName));
}
或使用RxJava:
private void fetchDetails2(List<Group> groupList) {
Observable.fromIterable(groupList)
.flatMap(g -> Observable.fromIterable(g.users).map(u -> new UserWithGroup(g, u)))
.flatMap(ug -> Observable.fromIterable(ug.user.detailNames).map(n -> new DetailWithUser(ug.group, ug.user, n)))
.flatMap(d -> mUserApi.getDetail(d.group.id, d.user.id, d.detailName)
.map(detail -> {
detail.group = d.group;
detail.user = d.user;
return detail
}))
.subscribeOn(Schedulers.io())
.observeOn(AndroidSchedulers.mainThread())
.subscribe(detail -> {
...
});
}
方法2:
Android.util.Pair
一個可以容納任何兩個對象的容器類。 如果使用此方法而不是創建中間容器,並且可以使用,則可以進一步簡化代碼。
Java 8流和配對:
private void fetchDetails3(List<Group> groupList) {
groupList.stream()
.flatMap(g -> g.users.stream().map(u -> Pair.create(g, u)))
.flatMap(p -> p.second.detailNames.stream().map(n -> Pair.create(p, n)))
.forEach(p -> fetchDetail(p.first.first, p.first.second, p.second));
}
RxJava和配對:
private void fetchDetails4(List<Group> groupList) {
Observable.fromIterable(groupList)
.flatMap(g -> Observable.fromIterable(g.users).map(u -> Pair.create(g, u)))
.flatMap(p -> Observable.fromIterable(p.second.detailNames).map(n -> Pair.create(p, n)))
.flatMap(p -> fetchDetail2(p.first.first, p.first.second, p.second)
.map(detail -> {
detail.group = d.group;
detail.user = d.user;
return detail
}))
.subscribeOn(Schedulers.io())
.observeOn(AndroidSchedulers.mainThread())
.subscribe(detail -> {
...
});
}
聲明:本站的技術帖子網頁,遵循CC BY-SA 4.0協議,如果您需要轉載,請注明本站網址或者原文地址。任何問題請咨詢:yoyou2525@163.com.