消耗REST API的最佳設計模式是什么

Question

我想在Laravel（一個MVC框架）中使用Rest API，但我求助於使用__call並且想知道是否有更好的設計模式。

我知道這是一個不好的選擇，我正在尋找其他模式，但這是我的Repository類：

namespace App\Repositories;

use App\Models\OnlinePayment;
use App\Models\Order;
use App\Models\Transaction;
use App\Models\User;
use GuzzleHttp\Client;
use Illuminate\Http\Request;
use Illuminate\Validation\ValidationException;
use SoapClient;

class Bank
{
    protected $http;
    protected $user;

    public function __construct()
    {
        $this->http = new Client;
    }

    protected function index()
    {
        $url = config('Bank.url') . '/v2/quantum/users/' . $this->user->national_id . '/report';

        $data = [
            'user_gender'       => $this->user->gender ?? 1,
            'user_name'         => $this->user->name,
            'user_family'       => $this->user->family ?? 'خالی',
            'user_mobile'       => $this->user->mobile,
            'user_type'         => $this->user->type->name,
        ];

        $options = $this->options($data);
        $res = $this->http->request('GET', $url, $options);

        $response = json_decode($res->getBody(), true);

        return $response;
    }

    protected function indexData($request)
    {
        $url = config('Bank.url') . '/v2/quantum/users/' . $this->user->national_id . '/customers';

        $options = $this->options($request->all());
        $res = $this->http->request('GET', $url, $options);
        $response = response()->json(json_decode($res->getBody(), true), $res->getStatusCode());
        return $response;
    }

    protected function show($national_id)
    {
        $url = config('Bank.url') . '/v2/quantum/users/' . $this->user->national_id . '/customers/' . $national_id;

        $options = $this->options([]);
        $res = $this->http->request('GET', $url, $options);

        if ($res->getStatusCode() == 404) {
            abort(404);
        }
        $response = json_decode($res->getBody(), true);

        return $response;

    }

    protected function store($request)
    {
        $http = new Client;
        $url = config('Bank.url') . '/v2/quantum/users/' . $this->user->national_id . '/customers';
        $this->user = auth()->user();

        $data = array_merge(
            [
                'customer_national_id'  => $request->national_id,
                'customer_gender'       => $request->gender,
                'customer_name'         => $request->name,
                'customer_family'       => $request->family,
                'customer_phone'        => $request->phone,
                'customer_mobile'       => $request->mobile,
                'customer_city_id'      => $request->city_id,
            ], [
                'user_name'         => $this->user->nanfig() is a hidden dependency. The settings should also be passed via the construcme,
                'user_family'       => $this->user->family ?? 'خالی',
                'user_mobile'       => $this->user->mobile,
                'user_type'         => $this->user->type->name,
                'user_gender'       => $this->user->gender ?? 1,
            ]
        );

        $res = $http->request('POST', $url, [
            'headers' => [
                'Accept'        => 'application/json',
                'Content-Type'  => 'application/json',
                'Authorization' => 'Bearer ' . config('Bank.token'),
            ],
            'json' => $data,
            'http_errors' => false
        ]);

        if (! in_array($res->getStatusCode(), [200, 422])) {
            $error = ValidationException::withMessages([
                'name' => 'خطای ' . $res->getStatusCode() . ' در تعویض کالا'
            ]);
            throw $error;
        }

        $response = response()->json(json_decode($res->getBody(), true), $res->getStatusCode());
        return $response;
    }

    protected function options($data)
    {
        $options = [
            'headers' => [
                'Accept'        => 'application/json',
                'Content-Type'  => 'application/json',
                'Authorization' => 'Bearer ' . config('Bank.token'),
            ],
            'json' => $data,
            'http_errors' => false
        ];

        return $options;
    }

    public function __call($method, $arguments) {
        if (method_exists($this, $method)) {

            if (! isset($arguments[0]) || ! $arguments[0] instanceof User) {
                $this->user = auth()->user();
            } else {
                $this->user = $arguments[0];
                unset($arguments[0]);
            }

            return call_user_func_array(array($this, $method), $arguments);
        }
    }
}

然后在控制器構造函數中創建它的一個實例：

    public function __construct()
    {

        $this->Bank = new Bank();
    }

並像這樣在控制器中使用它：

$response = $this->Bank->indexData($user, $request);

或這個：

$response = $this->Bank->indexData($request);

Answer 1

我認為顯示的類不是Repository類，因為Repository僅負責從數據源讀取和寫入日期。 您的課程做得太多，並且違反了所有基本的MVC原則。

有人認為我會解決：

• 存儲庫不負責創建響應視圖數據（如JSON）
• 存儲庫不負責創建響應對象
• 存儲庫獨立於請求/響應
• 方法名稱index沒有意義，因為存儲庫不是Controller動作。 不要將模型層與控制器層混合使用。
• config（）是隱藏的依賴項。 設置也應通過構造函數傳遞。

而是使用更好的分隔：

• 創建一個類BankApiClient
• 不要使用__call這樣的魔術方法
• 而是使用以下公共方法：getUserByNationalId（int $ nationalId）：UserData
• 等等...
• 讓控制器操作使用BankApiClient的結果創建/呈現json響應。

Answer 2

__call是php的一種魔術方法，它允許在對象實例外部執行受保護的方法，這是對類可見性的破壞。

如果要從外部調用方法，則它必須是公共的

 public function __construct()
 {
    $this->bank = new Bank()
 }

使用自動注入依賴項

public function __construct(Bank $bank)
{
   $this->bank = $bank;
}