如何在C ++ 11中插入std :: map？

Question

我正在嘗試將一對對值插入c ++ 11中的std::map中。 但是，這些值似乎沒有插入到std::map 。 請仔細檢查我的代碼。 我感謝所有幫助。

#include<iostream>
#include<string>
#include<algorithm>
#include<vector>
#include<map>
#include<cstdlib>
#include<utility>
#include<ctime>

#include "print.h"

class ReportCard
{
private:
    std::map<std::string, double> m_report_card;

public:
    std::map<std::string, double> getReportCardInstance() {  return m_report_card;  }
};

class Student
{

private:
    int m_roll_no;
    std::string m_name;
    ReportCard m_reportCard;

public:
    Student(int inRollNo, const std::string& inName) :
        m_roll_no(inRollNo), m_name(inName)
    {}

    std::string getName()   {   return m_name;  } 
    int getRollNo()     {   return m_roll_no;   }
    ReportCard getReportCard()  {   return self.m_reportCard;   }
    int getReportCardSize() {   return m_reportCard.getReportCardInstance().size(); }
};

class Driver
{
private:
    std::vector<Student> student_list;
    std::vector<Student> temp;

public:
    void studentTestPopulate()
    {
        student_list.push_back(Student(1, "Tim"));
        student_list.push_back(Student(2, "Matt"));
        student_list.push_back(Student(100, "Luke"));
        student_list.push_back(Student(68, "Lissy"));
        student_list.push_back(Student(20, "Tony"));
        student_list.push_back(Student(33, "Joseph"));
        student_list.push_back(Student(14, "Sid"));
        student_list.push_back(Student(15, "Roby"));
        student_list.push_back(Student(44, "Rohan"));
        student_list.push_back(Student(11, "Kevin"));
        student_list.push_back(Student(19, "George"));
    }
    void reportCardPopulate()
    {
        for (auto& student : student_list)
        {
            std::cout << student.getName() << std::endl;
            student.getReportCard().getReportCardInstance().insert(std::make_pair<std::string, double>("Math", generateMark));
            //This is the function that does not work. No marks are printed!!
            for (auto& mark : student.getReportCard().getReportCardInstance())
            {
                std::cout << mark.first << " " << mark.second;
            }
            //student.getReportCard().getReportCardInstance().insert(std::make_pair("Science", generateMark));
            //student.getReportCard().getReportCardInstance().insert(std::make_pair("Geography", generateMark));
            //student.getReportCard().getReportCardInstance().insert(std::make_pair("French", generateMark));
            //student.getReportCard().getReportCardInstance().insert(std::make_pair("History", generateMark));
        }
    }
    void showAllStudentDetails()
    {
        for (auto& student : student_list)
        {
            std::cout << student.getName() << std::endl;
            std::cout << student.getRollNo() << std::endl;
            std::cout << "REPORT CARD : " << student.getReportCardSize() << std::endl << std::endl;
            for (auto& mark : student.getReportCard().getReportCardInstance())
            {
                std::cout << mark.first << std::endl;
                std::cout << mark.second << std::endl;
            }
        }
    }
};

int main()
{
    srand(time(NULL));
    Driver driver;
    driver.studentTestPopulate();
    driver.reportCardPopulate();
    //driver.showAllStudentDetails();
}

reportCardPopulate()函數應該將值對插入到report_card映射中。 但是，插入功能似乎不起作用。

當我們嘗試打印reportCardPopulate()函數中的值時，它不會打印任何內容。 當我嘗試打印地圖的大小時 ，它將打印0 。 當我使用sizeof（）打印大小時，它在插入之前和之后都會打印相同的大小。

Answer 1

#include <iostream>
#include <map>

class ReportCard
{
   //private:  this is the default anyway for a class
   public: //made to be able to print the internals below.
        std::map<std::string, double> m_report_card;

   public:


        /* this returns an instance of the std::map. The map is copied and 
        returned, so any modifications will not affect m_report_card
        std::map<std::string, double> getReportCardInstance()
        {
            return m_report_card;
        }

        if you want to do this, return std::map<std::string, double>&.
        std::map<std::string, double>& getReportCardInstance()
        {
            return m_report_card;
        }
        */

        // better solution is to have a method to add the report

        void add_report(const std::string& first,double second)
        {
            m_report_card[first] = second;
        }  

};


int main() {
    ReportCard rc;
    rc.add_report("Percy",1.0);
    rc.add_report("Pig",2.0);

    for(auto internal_report_card : rc.m_report_card)
    {
        std::cout << internal_report_card.first << ", " 
                  << internal_report_card.second << std::endl;
    }

    return 0;
}

演示

Answer 2

以下功能

std::map<std::string, double> getReportCardInstance() { ... }
//^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
ReportCard getReportCard() { ... }
//^^^^^^^^

分別返回std::map<std::string, double>和ReportCard類的副本。 因此，無論您在此處插入什么

student.getReportCard().getReportCardInstance().insert(std::make_pair<std::string, double>("Math", generateMark));

對上述內容進行復制，因此ReportCard的原始成員（即m_report_card ）將永遠不會更新。 撥打完上述行后，副本將被銷毀，並期望它能正常工作。

其次，顯示代碼是錯誤的，因為在C ++中，你應該使用this沒有self

ReportCard getReportCard()
{
    return self.m_reportCard;
         //^^^^ --> should be `return this->m_reportCard;`
         // or simply         `return m_reportCard;`
}

更正以上內容，並通過引用返回該成員將使代碼正常工作。 （ 請參見在線直播 ）

std::map<std::string, double>& getReportCardInstance()
// ^^^^^^^^^^^^^^^^^^^^^^^^^^^
{
    return m_report_card;
}

ReportCard& getReportCard()
//^^^^^^^^
{
    return m_reportCard;
}

---

話雖ReportCard ，如果您執行上述操作，您的ReportCard和Student類將公開成員。 這不是一個好的設計。 如果這些僅用於Driver類的內部使用，則可以將其保留為Driver類的private屬性。

#include <vector>
#include <map>
#include <string>
#include <iostream>


class Driver /* final */ // -> optional
{
private: // Student is private for Driver class
    class Student
    {
        // type alias is enough for the map
        using ReportCard  = std::map<std::string, double>;
    private:
        int m_roll_no;
        std::string m_name;
        ReportCard m_reportCard;

    public:
        Student(int inRollNo, const std::string& inName)
            : m_roll_no{ inRollNo }, m_name{ inName }
        {}
        // make the member functions const if they are not modifing the members
        const std::string& getName() const { return m_name; }
        int getRollNo() const { return m_roll_no; }
        ReportCard& getReportCard() { return m_reportCard; }
        std::size_t getReportCardSize() const { return m_reportCard.size(); }
    };

private:
    std::vector<Student> student_list;
    std::vector<Student> temp;

public:
    void studentTestPopulate()
    {
        // construct the `Student` in-place using `std::vector::emplace_back`
        student_list.emplace_back(1, "Tim"); 
        student_list.emplace_back(2, "Matt");
        student_list.emplace_back(100, "Luke");
        student_list.emplace_back(68, "Lissy");
        student_list.emplace_back(20, "Tony");
        student_list.emplace_back(33, "Joseph");
        student_list.emplace_back(14, "Sid");
        student_list.emplace_back(15, "Roby");
        student_list.emplace_back(44, "Rohan");
        student_list.emplace_back(11, "Kevin");
        student_list.emplace_back(19, "George");
    }

    void reportCardPopulate()
    {
        for (auto& student : student_list)
        {
            std::cout << student.getName() << "\n";

            student.getReportCard().emplace(student.getName(), 12.0);
            //                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
            // use `std::map::emplace` for constructing `ReportCard` in-place
            for (auto& mark : student.getReportCard())
            {
                std::cout << mark.first << " " << mark.second << "\n";
            }
        }
    }
    // ... other members
};

int main()
{
    Driver driver;
    driver.studentTestPopulate();
    driver.reportCardPopulate();
}