[英]MySQL update doesn't work
我想根據用戶輸入更新數據庫的2個字段,我的代碼是這樣的:
<body>
<?php
$db_server["host"] = "localhost"; //database server
$db_server["username"] = "root"; // DB username
$db_server["password"] = "mypass"; // DB password
$db_server["database"] = "mudb";// database name
$dbc = mysql_connect($db_server["host"], $db_server["username"], $db_server["password"]);
mysql_select_db($db_server["database"], $dbc);
$user = $_COOKIE['mycookie'];
$q = "SELECT * FROM members WHERE username='$user'";
$r = mysql_query( $q,$dbc);
while ($row = mysql_fetch_array($r, MYSQLI_ASSOC)) {
echo 'username: '.$row['username'], '<br/>';
$password=$row['password'];
?>
<form method="post" id="changepasswordform" >
<input type="password" id="newpassword" name="newpassword"/>
<input type="submit" name="changepasswordbutton" >
</form>
<?php
echo 'email: '.$row['email'], '<br/>';
}
?>
<form method="post" id="changeemailform" >
<input type="text" id="newemail" name="newemail"/>
<input type="submit" value="αλλαγή" name="changeemailbutton" >
</form>
<?php
}
if (isset($_POST['changepasswordbutton'])){
$newpassword=$_POST['newpassword'];
$q2 = "UPDATE members SET password=$newpassword WHERE username='$user'";
$r2 = mysql_query($q2,$dbc);
}
if (isset($_POST['changeemailbutton'])){
$newemail=$_POST['newemail'];
$q3 = "UPDATE members SET email=$newemail WHERE username='$user'";
$r3 = @mysql_query( $q3,$dbc);
}
?>
</body>
但是,盡管我嘗試更新時與數據庫的連接正常(SELECT將按預期顯示結果),但數據庫中的值保持不變。我檢查了$ newpassword和$ newemail的值,它們每次都包含用戶輸入我在這里想念什么?
您缺少了密碼字段周圍的''
(引號)。 更改:
UPDATE members SET password=$newpassword WHERE username='$user'
至:
UPDATE members SET password='{mysql_real_escape_string($password)}'
WHERE username='{mysql_real_escape_string($user)}'
重要:
即使它不相關,也請不要使用mysql_*
函數-它已被棄用,並且容易受到sql注入的影響。 最好使用PDO或MySQLi。
這可以解決問題,並且可以保存以進行SQL注入( mysql_real_escape_string
):
$q2 = "UPDATE members SET
password='". mysql_real_escape_string($password) ."'
WHERE username='". mysql_real_escape_string($user) ."';
但是,當然,您不應該再使用mysql_*
,我只是為您的特定情況提供示例。
聲明:本站的技術帖子網頁,遵循CC BY-SA 4.0協議,如果您需要轉載,請注明本站網址或者原文地址。任何問題請咨詢:yoyou2525@163.com.