![](/img/trans.png)
[英]bsearch() in C giving segmentation fault in new gcc version 7.4.0
[英]C bsearch causing segmentation fault
我有函數調用userInteractive(* anangramInfo),它傳入struct anangramInfo的指針,這個struct包含指向實際anagrams的指針“anagramPointer”。 所以,我從用戶那里得到了stdin。 然后使用它作為bsearch的鍵來找到指針thoese anagram具有相同的anangram.sorted。 然后將指針移動到左邊,直到鍵與anagram.sorted不匹配,然后向右移動打印anagram.word,直到anagram.sorted不匹配。 但它導致我的分割問題
#include <string.h>
#include <errno.h>
#include <ctype.h>
#include "anagrams.h"
#include <unistd.h>
#include <sys/stat.h>
#include <sys/types.h>
#define SIZE 80
//struct
struct anagram {
char word[SIZE];
char sorted[SIZE];
};
struct anagramInfo {
struct anagram *anagramPtr;
int numOfAnagrams;
};
/* qsort struct comparision function (product C-string field) */
int sortedMemberCompare( const void *ptr1, const void *ptr2 )
{
struct anagram *ia = (struct anagram *)ptr1;
struct anagram *ib = (struct anagram *)ptr2;
return strcmp(ia->sorted, ib->sorted);
/* strcmp functions works exactly as expected from
comparison function */
}
void userInteractive( struct anagramInfo *anagramInfoPtr ){
struct anagram a;
char data[SIZE];
char *pos;
printf("Enter a word to search for anagrams [^D to exit]:\n");
fgets(data, SIZE, stdin);
//get ripe of the '\n'
pos=strchr(data, '\n');
*pos = '\0';
strncpy(a.word,data,sizeof(data));
//lowercase word
int i;
for(i=0;data[i] != '\0';i++)
{
data[i]=(char)tolower(data[i]);
}
/* sort array using qsort functions */
qsort(data,strlen(data), 1, charCompare);
strncpy(a.sorted,data,sizeof(data));
//struct pointer to the elements
struct anagram *ptr= (struct anagram *)bsearch(a.sorted,anagramInfoPtr-> anagramPtr ->sorted,anagramInfoPtr-> numOfAnagrams,sizeof(struct anagram),sortedMemberCompare);
printf(ptr->word);
while(strncmp(ptr ->sorted,a.sorted,sizeof(a.sorted))==0) {
ptr--;
}
while(strncmp(ptr ->sorted,a.sorted,sizeof(a.sorted))==0) {
printf(ptr ->word);
printf(" ");
ptr++;
}
}
你的疏忽是bsearch
沒有在一個連續的數組上搜索 ; 它甚至沒有在正確的位置搜索,因為您正在搜索已排序的字符串 ,但您應該搜索已排序的字謎成員 :
struct anagram *ptr = (struct anagram *)bsearch(&a,
anagramInfoPtr-> anagramPtr,
anagramInfoPtr-> numOfAnagrams,
sizeof(struct anagram),
sortedMemberCompare);
然后,當bsearch
失敗並返回NULL
,你不檢查ptr
是否為NULL
並使用它; 因此,段錯誤。 (您也不要在Ctrl-D處檢查NULL
)。
這是一個修改過的版本 - 我添加了一個charCompare
函數並用一個時尚的方式將一個帶有五個固定字符串的main()
掀起來使其工作。
#include <string.h>
#include <errno.h>
#include <stdio.h>
#include <stdlib.h>
#include <ctype.h>
#include <unistd.h>
#include <sys/stat.h>
#include <sys/types.h>
#define SIZE 80
//struct
struct anagram {
char word[SIZE];
char sorted[SIZE];
};
struct anagramInfo {
struct anagram *anagramPtr;
int numOfAnagrams;
};
/* qsort struct comparision function (product C-string field) */
int sortedMemberCompare( const void *ptr1, const void *ptr2 )
{
struct anagram *ia = (struct anagram *)ptr1;
struct anagram *ib = (struct anagram *)ptr2;
return strcmp(ia->sorted, ib->sorted);
/* strcmp functions works exactly as expected from
comparison function */
}
int charCompare(const void *a, const void *b)
{
const char *aa = a, *bb = b;
if (*aa < *bb)
return -1;
if (*aa == *bb)
return 0;
return 1;
}
void userInteractive( struct anagramInfo *anagramInfoPtr ){
struct anagram a;
char data[SIZE];
char *pos;
printf("Enter a word to search for anagrams [^D to exit]:\n");
fgets(data, SIZE, stdin);
//get ripe of the '\n'
pos=strchr(data, '\n'); // In Windows this might be a "\r" maybe?
if (NULL == pos)
exit(0);
*pos = '\0';
strncpy(a.word,data,sizeof(data));
//lowercase word
int i;
for(i=0;data[i] != '\0';i++)
{
data[i]=(char)tolower(data[i]);
}
/* sort array using qsort functions */
qsort(data, strlen(data), 1, charCompare);
strncpy(a.sorted,data,sizeof(data));
//struct pointer to the elements
struct anagram *ptr = (struct anagram *)bsearch(&a,
anagramInfoPtr-> anagramPtr,
anagramInfoPtr-> numOfAnagrams,
sizeof(struct anagram),
sortedMemberCompare);
// You must check that ptr is not NULL.
if (NULL == ptr)
{
printf("Not found\n");
return;
}
printf("Found: %s\n", ptr->word);
/* Here there is a subtle error. If you find the FIRST item of the list,
this code will position itself BEFORE THE BEGINNING of the list, and
run a strncmp() against who knows what. Other segfault lurking! */
while(ptr > anagramInfoPtr -> anagramPtr && strncmp(ptr ->sorted,a.sorted,strlen(a.sorted))==0) {
ptr--;
}
// while(strncmp(ptr ->sorted,a.sorted,sizeof(a.sorted))==0) {
// ptr--;
//}
// Here too you should check you do not pass max number of anagrams,
// if you hit the last item of the lot.
while(strncmp(ptr ->sorted,a.sorted,sizeof(a.sorted))==0) {
printf(ptr ->word);
printf(" ");
ptr++;
}
}
int main()
{
int i;
struct anagramInfo *root;
root = malloc(sizeof(struct anagramInfo));
root->numOfAnagrams = 5;
root->anagramPtr = malloc(root->numOfAnagrams * sizeof(struct anagram));
strcpy(root->anagramPtr[0].word, "oriental");
strcpy(root->anagramPtr[1].word, "teaching");
strcpy(root->anagramPtr[2].word, "senator");
strcpy(root->anagramPtr[3].word, "admirer");
strcpy(root->anagramPtr[4].word, "rescued");
for (i = 0; i < root->numOfAnagrams; i++)
{
int j;
for (j = 0; root->anagramPtr[i].word[j]; j++)
root->anagramPtr[i].word[j] = tolower(root->anagramPtr[i].word[j]);
strcpy(root->anagramPtr[i].sorted, root->anagramPtr[i].word);
qsort(root->anagramPtr[i].sorted, strlen(root->anagramPtr[i].sorted), 1, charCompare);
}
qsort(root-> anagramPtr, root-> numOfAnagrams, sizeof(struct anagram), sortedMemberCompare);
for (;;)
userInteractive(root);
}
$ gcc -W -Wall -o anagram anagram.c
$ ./anagram
Enter a word to search for anagrams [^D to exit]:
treason
Found: senator
Enter a word to search for anagrams [^D to exit]:
cheating
Found: teaching
Enter a word to search for anagrams [^D to exit]:
relation
Found: oriental
Enter a word to search for anagrams [^D to exit]:
$
聲明:本站的技術帖子網頁,遵循CC BY-SA 4.0協議,如果您需要轉載,請注明本站網址或者原文地址。任何問題請咨詢:yoyou2525@163.com.