多个文件用于读取和保存

Question

I have multiple files to read and also do heatmap after which the outputs will be saved. Somehow, there is a problem(s) with my code below and I can't figure out why it is not working. Files: mxn.dat, scu.dat, emun.dat, ser.dat

files <- list.files(pattern=".dat")
for (i in length(files)){
data <-read.table(files[i],row.names=1,header=T,sep='\t')
  for in length(files){
  png('i.png') 
  pheatmap(t(data[i]), cellwidth = 32, cellheight = 14, fontsize = 5, show_colnames =  T, cluster_cols = FALSE)
  dev.off()
  } 
}

Any help will be appreciated to get the code working.

Thanks

Rob

Answer 1

Not a reproducible example so I have no way to test if this will work (and somehow I think that this is too localised to be useful to future visitors), but perhaps try this...

files <- list.files(pattern=".dat")

for (i in 1:length(files)){
  data <-read.table( files[i],row.names=1,header=T,sep='\t')
  png( paste0( i , '.png' ) )
    pheatmap( t( data ), cellwidth = 32, cellheight = 14, fontsize = 5, show_colnames =  T, cluster_cols = FALSE)
  dev.off()
  } 

Answer 2

Variation of SimonO101's solution:

files <- list.files(pattern=".dat")

for( f in files )
{
  data <-read.table( f, row.names = TRUE, header = TRUE, sep = '\t' )
  png( gsub( "pdf", "png", f ) )
  pheatmap( t( data ), cellwidth = 32, cellheight = 14, fontsize = 5, show_colnames =  T,    cluster_cols = FALSE)
  dev.off()
} 

Easier to read (I believe) and has the advantage (?) of preserving the original file names, only changing the extension.