在函数中修改动态2D数组

Question

I've got a function that accepts a dynamic multidimensional array (which is initialized to 0) as a parameter, and I'm trying to modify certain values within the array in my function.

The function that accepts the array as a parameter is supposed to simulate the roll of two dice and output the frequency distribution to the array I made that's initialized to zero.

The code for it is as follows:

#include <iostream>
#include <cstdlib>

using namespace std;

int** rollDie(int numRolls, unsigned short seed, int** &rollarray)
{
srand(seed);
int side1, side2;
while (numRolls > 0)
{
side1 = 1 + rand() % 6;
side2 = 1 + rand() % 6;

rollarray[side1][side2]++;

numRolls--;
}
return rollarray;

}

int** initializeArray(void)
{
    int i, j;
    int** m = new int*[6];

    for (i = 0; i < 6; i++)
        m[i] = new int[6];

    for (i = 0; i < 6; i++)
        for (j = 0; j < 6; j++)
            m[i][j] = 0;

    return m;
}

int main()
{
int numRolls;
unsigned short seed;
int ** a = initializeArray();


cout << "rolls?\n";
cin >> numRolls;

cout << "seed?\n";
cin >> seed;
int ** b = rollDie(numRolls, seed, a);

int i,j;
for (i = 0; i < 6; i++) {
    for (j = 0; j < 6; j++) {
        cout << b[i][j];
    }
    cout << "\n";
    }

}

Answer 1

Code works for me with just a few issues (I had to guess how you defined a . Next time add that too):

In the printing you should print a space after every number (minor)

In the random, you choose index as 1+rand()%6 , so from 1 to 6, but when you print you take indexes from 0 to 5! So your first row and first column will be 0.

Other than that it seems to work.

Answer 2

Only when one goes and does something else does the answer come to mind. I suspect you declared a as:

int a[6][6];

which is an array of 36 integers. In your function, though, you're declaring rollarray to be a pointer to an array of pointers to integers. All you need to do is change the function signature to:

int* rollDie(int numRolls, unsigned short seed, int* rollarray)

As cluracan said, you also want to use array indices in the range 0 to 5.

This is a good case for either the judicious use of print statements or stepping through with a debugger to see what's really going on.