按名称查找重复项时出错

Question

I have written a program which would find duplicates by name. Eg:Lets say we have file a.txt,b.txt,c.txt in various directories.I need to find the files which are duplicated only by their name.The output would be the filename which are present in various directories.

Code:

fs::path tempHolder;
int isDuplicate=0;//To check whether duplicate or not.
vec::const_iterator tempit (v.begin());//i already have vector v which has all the filenames
for (vec::const_iterator it (v.begin()); it != v.end();)
{

   tempHolder=*it;
   isDuplicate=0;
   tempit=it;
   while((++tempit)!=v.end() && tempHolder==(*(++it)))
   {
      isDuplicate=1;
   }
   if(isDuplicate==1)
   {
      cout<<"Duplicate:"<<tempHolder<<endl;
   }
 }

The problem is the for loop is going recursively but it prints the duplicate filename properly.Thanks.

Answer 1

This loop seems strange to me:

tempit=it;
while((++tempit)!=v.end() && tempHolder==(*(++it)))
{
    isDuplicate=1;
}

If it is the last valid iterator of the container, the first condition will be false, so short-circuit evaluation will cause ++it to never be executed. The loop will run indefinitely.

while((++tempit)!=v.end() && tempHolder==*tempit)

should work.

Answer 2

while((++tempit)!=v.end() && tempHolder==(*(++it)))

You manipulate your iterator that you use in your big loop (it) Better:

while((++tempit)!=v.end() && tempHolder==(*tempit))

If I understand your code correctly.

Edit: And your it needs to be incremented in your first loop.

I personally would rather write something like that:

while ((++tempit)!= v.end())
    if (*tempit = *it)
    {
        duplicate = true;
        break;
    }