从Grails 1.x迁移到2.3.9并修复Spock测试以在流程中运行

Question

I have a question about Spock testing the list() method in a controller. I am also migrating from Grails 1.x to Grails 2.3.9. The question is how do I get the mock object I am creating visible to the controller so that when I call list() on it it sees the mock object.

Here is the code from the controller under test:

class XxCatalogFormController {
    def list() {
    params.max = Math.min(params.max ? params.int('max') : 10, 100)
    [dpCatalogFormInstanceList: XxCatalogForm.list(), dpCatalogFormInstanceTotal: XxCatalogForm.count()]
}  

Here is the Spock test I have:

@TestFor(XpCatalogFormController)
@Mock([XxCatalogForm, DpCatalog])
@TestMixin(GrailsUnitTestMixin)
class XpCatalogFormControllerSpec extends Specification {
    def 'list action: 1 dpCatalogForm'() {
    setup:
    mockDomain(XxCatalogForm, [dpCatalogFormInstance])
    mockDomain(DpCatalog, [catalog])
    params.max = 1
    when:

expect:
    controller.list() == [dpCatalogFormInstanceList: [dpCatalogFormInstance], dpCatalogFormInstanceTotal: 1]

    where:
    catalog = new DpCatalog(name: 'TestCatalog')
    dpCatalogFormInstance = new XxCatalogForm(url: 'catalog_testForm.gsp',
            catalog: catalog, confirmMessage: 'test', introBannerUrl: '/site/test.gsp',
            successUrl: 'test.gsp', name: 'test')

}

And here is the test result:

Condition not satisfied: controller.list() == [dpCatalogFormInstanceList: [dpCatalogFormInstance], dpCatalogFormInstanceTotal: 1] | | | | | | false com.kpi.dp.catalog.XxCatalogForm : (unsaved) | [dpCatalogFormInstanceList:[], dpCatalogFormInstanceTotal:0] com.kpi.dp.catalog.XxCatalogFormController@784f6502
junit.framework.AssertionFailedError: Condition not satisfied:

controller.list() == [dpCatalogFormInstanceList: [dpCatalogFormInstance], dpCatalogFormInstanceTotal: 1]
|          |      |                               |
|          |      false                                 com.kpi.dp.catalog.XxCatalogForm : (unsaved)
|          [dpCatalogFormInstanceList:[], dpCatalogFormInstanceTotal:0]
com.kpi.dp.catalog.XxCatalogFormController@784f6502

at com.kpi.dp.catalog.XxCatalogFormControllerSpec.list action: 1 dpCatalogForm(XxCatalogFormControllerSpec.groovy:64)

Answer 1

Unable to confirm which mixin is used in the test class, modifying the test class to use @Mock should work. Use @Mock instead of mockDomain() . Expecting the class to be under test/unit .

import grails.test.mixin.*
import spock.lang.Specification

@TestFor(XxCatalogFormController)
@Mock([DpCatalog, XxCatalogForm])
class XxCatalogFormControllerSpec extends Specification {

    def 'list action: 1 dpCatalogForm'() {
        given:
        def catalog = new DpCatalog(name: 'TestCatalog')
        def dpCatalogFormInstance = new XxCatalogForm(
            url: 'catalog_testForm.gsp',
            catalog: catalog, 
            confirmMessage: 'test', 
            introBannerUrl: '/site/test.gsp',
            successUrl: 'test.gsp', name: 'test'
        )

        and:
        params.max = 1

        expect:
        controller.list() == [
            dpCatalogFormInstanceList: [dpCatalogFormInstance], 
            dpCatalogFormInstanceTotal: 1
        ]
    }
}