BroadcastReveiver未注册

Question

I cannot figure out why I keep getting an error saying:

11-10 17:14:04.904: E/AndroidRuntime(8151): Caused by: java.lang.IllegalArgumentException: Receiver not registered: com.refect.served.fragment.activities.DrinkReleaseStation$PushBroadcastReceiver@541e0ce4

I clearly register my receiver on my onCreate() method. But when I try unregistering it, it crashes and gives me that error. Here's the rest of my code:

public class DrinkReleaseStation extends FragmentActivity {

    private PushBroadcastReceiver receiver;

    @Override
    protected void onCreate(Bundle savedInstanceState) {
        super.onCreate(savedInstanceState);
        setContentView(R.layout.admin_new_bar);

        String barId = getIntent().getExtras().getString("BarId");
        orders = new ArrayList<ParseObjectModel>();

        saveInstallation(barId);

        ordersListView = (ListView) findViewById(R.id.lv_bars);
        adapter = new DrinkManagerAdapter(this, orders);
        ordersListView.setAdapter(adapter);

        fab = (Button) findViewById(R.id.btn_add_new_bar);
        //fab.setDrawable(getResources().getDrawable(R.drawable.ic_navigation_accept));

        registerReceiver();

    } //end onCreate

@Override
public void onResume() {
    super.onResume();
    registerReceiver();
}

@Override
public void onDestroy() {
    super.onDestroy();
    unregisterReceiver(receiver);
    unsubscribeInstallation();
}

@Override
public void onPause() {
    super.onPause();
    unregisterReceiver(receiver);
    unsubscribeInstallation();
}

    private void registerReceiver() {
        receiver = new PushBroadcastReceiver();

        IntentFilter filter = new IntentFilter();
//      filter.addAction(Intent.ACTION_BOOT_COMPLETED);
//      filter.addAction(Intent.ACTION_USER_PRESENT);
        filter.addAction("com.google.android.c2dm.intent.RECEIVE");
        registerReceiver(receiver, filter);
        Log.d("ReleaseStation", "Receiver Registered");
    }

    /**
     * BroadcastReceiver for receiving 
     * push messages from Parse
     * @author Austin
     *
     */
    public class PushBroadcastReceiver extends BroadcastReceiver {

        @Override
        public void onReceive(Context context, Intent intent) {

            if(intent.getAction().equals("com.google.android.c2dm.intent.RECEIVE")) {
                Log.d("Order", intent.getAction());
                Toast.makeText(context, "New Order!.",
                        Toast.LENGTH_SHORT).show();
            }
        }
    }

}

Answer 1

You are calling unregisterReceiver() in both onPause() and onDestroy() . It is guaranteed that by the time onDestroy() is called, onPause() will have been called. Hence, get rid of the onDestroy() call to unregisterReceiver() , and you should be in better shape.

Generally speaking, stick to the pairs:

• if you initialize it in onCreate() , clean it up in onDestroy()
• if you initialize it in onStart() , clean it up in onStop()
• if you initialize it in onResume() , clean it up in onPause()