将存储的值附加到Twitter意图URL

Question

I am running a name generator script that allows a user to input their first and last name, and then populates a div with their "silly name." Here is that javascript:

<script>

window.onload = initAll;

function initAll() {
    document.getElementById("submit-button").onclick = getSillyName;
}

function getSillyName() {
    document.getElementById("answer").innerHTML = getSillyNameString();
    return false;
}

function getSillyNameString() {
    var firstName = new Array("Peso", "Versace", "Purp", "Purple", "Palace", "Harlem", "Pretty", "Flacko", "Cake", "Goldie", "Trillmatic", "Lord", "Trill", "Ty", "Dolce", "Gucci", "Jodye", "Versace", "Guapanese", "Guapito", "Keef", "Reefer", "Codein", "Ford", "Papi", "Basquiat");
    var lastName1 = new Array("Swisher", "Benz", "Clams", "Kush", "Margiela", "Trillmatic", "Eleveny", "Berg", "Gordo", "1Train", "Phoenix", "Guapo", "1Train", "Dulce", "Laurent", "Milan", "Clams", "Uptown", "Lean", "Guapo", "Flackito", "Testarossa", "Swisha", "Pesos", "Beretta", "Balenciaga");

    var firstNm = document.getElementById("fName").value.toUpperCase();
    var lastNm = document.getElementById("lName").value.toUpperCase();
    var validName = true;

    if (firstNm == "") {
        validName = false;
    }
    else {
        var firstNum = firstNm.charCodeAt(0) - 65;
        if (firstNum < 0 || firstNum > 25) {
            validName = false;
        }
    }

    if (!validName) {
        document.getElementById("fName").focus();
        document.getElementById("fName").select();
        return "enter your name below";
    }

    if (lastNm == "") {
        validName = false;
    }
    else {
        var lastNum1 = lastNm.charCodeAt(0) - 65;

        if (lastNum1 < 0 || lastNum1 > 25) {
            validName = false;
        }
    }

    if (!validName) {
        document.getElementById("lName").focus();
        document.getElementById("lName").select();
        return "enter your name below";
    }

    return "Your name is " + firstName[firstNum] + " " + lastName1[lastNum1];
}

</script>

After they recieve their name, I would like to append the generated name to a twitter intent url:

<a id="custom-tweet-button" href="https://twitter.com/intent/tweet?text=My%20silly%20name%20is">Tweet</a>

How can I accomplish this URL append with the existing code? Any help would be appreciated, and thanks!

Answer 1

I know this is pretty basic Javascript, but I figured it out. I added to the last function, getSillyNameString():

var tweettext = firstName[firstNum] + "%20" + lastName1[lastNum1];
document.getElementById("custom-tweet-button").href = "https://twitter.com/intent/tweet?text=My%20A%24AP%20Mob%20name%20is%20" + tweettext +"&hashtags=A%24AP%20Mob%2CA%24AP%20Rocky&via=MTVNews&url=http%3A%2F%2Fon.mtv.com%2F17B95Hu";

return "Your name is A$AP " + firstName[firstNum] + " " + lastName1[lastNum1];

Twitter web intent needs the URL encoded, which I did manually.

This changes a placeholder href attribute dynamically. Good to go!

If anyone sees a better/ cleaner way to accomplish this, I'd be happy to hear it.