声纳问题-阵列直接存储

Question

I have a method wherein i'm directly assigning the method argument to a class variable.

public void sample(String[] targets)
{
    this.objects = Targets;
}

One solution i found out is creatig a new copy of the array using Arrays.copy(targets). But i'm worried if this would effect the performance of the system.

I have two questions :

Firstly, how big the Impact is if i use Arrays.copy().

If the Impact is big(if the array length is high), then is there any other solution to fix this sonar issue without impacting the Performance.

Answer 1

The Sonar hint advises you to make a defensive copy of the given array. Generally speaking, you should follow that advise, because otherwise, your code could produce bugs, which are caused by unwanted side-effects and therefor hard to localize.

Usually, the performance impact by defensive copying is neglectible, due to it's unnoticeable overhead. More important for the decision pro/against defensive copy is its influence on other aspects of code quality, such as readibility, usability and stability.

As long as sample() is called infrequently, you don't need to hesitate making array copies.