一个AngularJS文件中有多少个控制器（服务，工厂，指令）

Question

My AngularJS application is growing and we have over one hundred controllers, services and directives in one file. Line count is approaching 25,000 and I'm wondering if I am approaching some limit (Angular, JavaScript or otherwise). Am I?

Answer 1

You should just do one thing (one controller, one service, one module) per file and structure your files into an organized folder structure, so that it is easy to find code (and to seperate scopes using IIFE s). I recommend to read a style guide or an article on the topic .

The total amount of controllers, services etc. that can exist in your application are only limited by your RAM. Performance should not be influenced, as searching for controllers/services to inject is O(n) if not better(its just a simple lookup that happens once per injection/instantiation).

Answer 2

There probably isn't really a line limit, but I can imagine your file being insanely chaotic and almost unreadable. You should consider to split your 1 file in a couple of files, like 1 file for your controllers (or if you have clear groupings of controllers, separate the controllers in a few files aswell) and 1 file for your services etc. You can create new modules for the services and controllers and then inject those in your main module.

The huge advantage: your code is much easier to maintain and understand, and it is much easier to track down errors and bugs instead of having to scroll through 25k lines of code.

Also, should you for some reason pass the project on to someone else, he/she will be able to read your project and actually be able to adjust/expand it without spending weeks trying to figure the entire thing out.

imagine some1 getting acces to your file and replace all your ';' with the greek questionmark, which looks pretty much identical. Good luck figuring that out if all your code is in 1 file!

Answer 3

25,000 lines with over 100 controllers/services/directives in a single file can't be good. Consider breaking up your application into various folders (controllers, services, directives, views, etc.) and try and keep as little code per file as possible. Ideally, 1 service/controller per file when in development! How do you even deal with that much code in a single file when developing? You can concat and minify everything with Gulp/Grunt when linking to your index/html file.