turbo c 3.0 DOS box中程序异常终止

Question

I am getting an error Abnormal program termination when I execute this code.

The objective the program is read array of numbers from file list.txt and perform recursive binary and recursive linear search on that loaded array.

Here is my code:

#include <stdio.h>
#include <conio.h>

void menu();

int a[30000],n;

void main()
{
    FILE *fp;
    int i, ch;

    fp = fopen("list.txt", "r");
    if(fp == NULL)
    {
        printf("\nCant read\n");
        exit(0);
    }

    for(i = 0; i < n; i++)
        fscanf(fp, "%d", &a[i]);

    fclose(fp);

    for(i = 0; i < n; i++)
        printf(" %d ", a[i]);

    menu();

    scanf("%d", &ch);
    if(ch == 1)
    {
        printf("ch1\n");
    }
    else if(ch == 2)
    {
        printf("ch2\n");
    }
    else
    {
        exit(1);
    }
}//end main



void menu()
{
    printf("\nEnter the number of elements in array\n");
    scanf("%d", &n);
    printf("\n1.Linear Search\n2.Binary Search\n3.Exit\nEnter your choice\n");
}

I have the logic for my choice 1 and 2. I need to know whats wrong with my above code. Please help me out in this

Answer 1

Turbo C! That brings back some memories, but I don't have my copy any more. Anyway, you're using n before you initialize it in menu() . (As the commenters pointed out.) You might also consider allocating your array with malloc() instead of a fixed size.

Borland Turbo C came with Turbo Debugger, and in fact I think Borland gave it away for free for a while, so running in that can give you an idea where the abnormal termination happened and a stack trace you can use to check the variables that caused it. Another good practice is to put in assert() calls to make sure your assumptions about what's in your variables are true.