摆脱无参数重新分配错误（eslint）的最佳方法是什么？

Question

I'm currently trying out eslint on this code and ran into an error (see screenshot). I'm not sure of what is the best way to get rid of the error.

code snippet:

let pathFor = ( path, view ) => {
  if ( path.hash ) {
    view = path;
    path = view.hash.route;
    delete view.hash.route;
  }

attempt to get rid of error (which works but not sure if it's the best way):

let pathFor = ( pathData, viewData ) => {
  if ( pathData.hash ) {
    view = pathData;
    path = view.hash.route;
    delete view.hash.route;
  }

Here is the screenshot of eslinting in sublime

Answer 1

Lots of ways to do it. The linter is throwing at error because you're mutating a parameter, which can appear obfuscated to people reading your code, or cause other problems down the line. A more "functional style" of programming is basically what the linter is recommending (creating a new variable instead of mutating an old one), and probably rightly so. A method I've used in the past is with "Hungarian case":

let pathFor = (_path, _view) => {
  if (_path.hash) {
    view = _path;
    path = view.hash.route;
    delete view.hash.route;
  }

However, the little underscores can be arbitrary in their meaning depending on who's reading your code.

But, I think the way you have it is just fine. As Phil Karlton said:

There are only two hard things in Computer Science: cache invalidation and naming things.

I think this question is more a question of "best naming practices" more than anything. If that's the case, I wouldn't waste too much mental energy on it.