矩阵模板添加运算符重载

Question

I have a task to write a template Matrix class with some specific functions. operator= , copy constructor and parameter constructor work fine I think. There is a problem with operator+ . For example when I add 2 matrixes filled only with number 5 I got strange numbers in whole row 1 and whole column m without element in last row. Something like that (o - okay, x - wrong result).

xxxx
ooox
ooox
oooo

header file

template <typename T> class Matrix {
    int n, m;  //dimensions
    T** arr;

public:
    Matrix();
    Matrix(int row, int column, const T& value);
    Matrix(const Matrix<T>& copy);
    ~Matrix();
    void init(int row, int column, T** ar);

    template <typename O>
    friend std::ostream& operator<<(std::ostream& out, const Matrix<O>& t);

    Matrix<T>& operator=(const Matrix<T>& rhs);
    Matrix<T>& operator+=(const Matrix<T>& rhs);
    Matrix<T>& operator+(const Matrix<T>& rhs);
};

cpp file

template <typename T>
void Matrix<T>::init(int row, int column, T** a) {
    n = row;
    m = column;
    arr = new int *[n];
    for (unsigned i = 0; i < n; i++)
        arr[i] = new int[m];
    if (a) {
        for (unsigned i = 0; i < n; i++)
            for (unsigned j = 0; j < m; j++)
                arr[i][j] = a[i][j];
    }
}

template <typename T>
Matrix<T>::Matrix() {
    init(2,2, arr);
}

template <typename T>
Matrix<T>::Matrix(int row, int column, const T& value) {
    n = row;
    m = column;

    arr = new int *[n];
    for (unsigned i=0; i < n; i++)
        arr[i] = new int[m];

    for(unsigned i=0; i<n; i++)
        for(unsigned j=0; j<m; j++)
            arr[i][j] = value;
}

template <typename T>
Matrix<T>::Matrix(const Matrix<T>& mat_copy) {
    n = mat_copy.n;
    m = mat_copy.m;
    init(mat_copy.n, mat_copy.m, mat_copy.arr);
}

template <typename T>
Matrix<T>::~Matrix() {
    for(unsigned i=0; i<n; i++)
        delete[] arr[i];
    delete[] arr;
}

template <typename T>
Matrix<T>& Matrix<T>::operator=(const Matrix<T>& T1) {
    if(this == &T1) return *this;
    for(unsigned i=0; i<n; i++)
        delete [] arr[i];
    delete  [] arr;
    init(T1.n, T1.m, T1.arr);

    return *this;
 }

 template <typename T>
 std::ostream& operator<<(std::ostream& out, const Matrix<T>& t) {
     for(unsigned i=0; i<t.n; i++) {
        std::cout << std::endl;
        for(unsigned j=0; j<t.n; j++)
            out << t.arr[i][j] << " ";
    }
    std::cout << std::endl;
    return out;
}

template <typename T>
Matrix<T>& Matrix<T>::operator+(const Matrix<T>& rhs) {
    int rows = n;
    int columns = m;
    Matrix result(rows,columns,0);

    for (unsigned i = 0; i < rows; i++)
        for (unsigned j = 0; j < columns; j++)
            result.arr[i][j] = (*this).arr[i][j] + rhs.arr[i][j];

    return result;
}

Any ideas how to fix that? I would be grateful for your help and advices with improving it because probably there will be some mistakes.

I use the newest CLion release with updated cygwin compiler.

Answer 1

I suspect the problem is caused by the return value of the operator+() function. You are returning a reference to an object that is local to the function.

template <typename T>
Matrix<T>& Matrix<T>::operator+(const Matrix<T>& rhs) {
    int rows = n;
    int columns = m;
    Matrix result(rows,columns,0);

    for (unsigned i = 0; i < rows; i++)
        for (unsigned j = 0; j < columns; j++)
            result.arr[i][j] = (*this).arr[i][j] + rhs.arr[i][j];

    // Returning a reference to a function local object.
    // The reference will be a dangling reference when the function returns.
    return result;
}

Change the return type to be an object.

template <typename T>
Matrix<T> Matrix<T>::operator+(const Matrix<T>& rhs) {
    int rows = n;
    int columns = m;
    Matrix result(rows,columns,0);

    for (unsigned i = 0; i < rows; i++)
        for (unsigned j = 0; j < columns; j++)
            result.arr[i][j] = (*this).arr[i][j] + rhs.arr[i][j];

    return result;
}

Answer 2

Several comments:

1) (probably the source of your problem), the upper-bound of the j iterator in the operator<< method is wrong, it should be:

for(unsigned j=0; j<t.m; j++)

2) The constructor Matrix<T>(int row, int column, const T& value) should be calling the init method and not reimplement it.

3) init should be private

4) It makes no sense to provide a default constructor which creates a 2x2 matrix! The default constructor should create an empty matrix 0x0!

5) Before summing the matrices you should check whether they are compatible for such operation.

6) I hope you are not looking for performance because the way you laid down the matrix in memory is not cache friendly and not going to be fast!