[英]Segmentation Fault occurring with Quicksort
int main() {
int yearsToLoop;
cin >> yearsToLoop;
annual_stats* ptr = new annual_stats [yearsToLoop];
for (int i = 0; i < yearsToLoop; i++)
{
int annualYear;
cin >> annualYear;
ptr[i].year = annualYear;
for (int j = 0; j < NO_TEAMS; j++)
{
string team_name;
getline(cin, team_name, '\t');
strcpy(ptr[i].teams[j].team_name, team_name.c_str());
int games;
cin >> games;
ptr[i].teams[j].games = games;
float pts_per_game;
cin >> pts_per_game;
ptr[i].teams[j].pts_per_game = pts_per_game;
int total_points;
cin >> total_points;
ptr[i].teams[j].total_points = total_points;
int scrimmage_plays;
cin >> scrimmage_plays;
ptr[i].teams[j].scrimmage_plays = scrimmage_plays;
float yds_per_game;
cin >> yds_per_game;
ptr[i].teams[j].yds_per_game = yds_per_game;
float yds_per_play;
cin >> yds_per_play;
ptr[i].teams[j].yds_per_play = yds_per_play;
float first_per_game;
cin >> first_per_game;
ptr[i].teams[j].first_per_game = first_per_game;
int third_md;
cin >> third_md;
ptr[i].teams[j].third_md = third_md;
int third_att;
cin >> third_att;
ptr[i].teams[j].third_att = third_att;
int third_pct;
cin >> third_pct;
ptr[i].teams[j].third_pct = third_pct;
int fourth_md;
cin >> fourth_md;
ptr[i].teams[j].fourth_md = fourth_md;
int fourth_att;
cin >> fourth_att;
ptr[i].teams[j].fourth_att = fourth_att;
int fourth_pct;
cin >> fourth_pct;
ptr[i].teams[j].fourth_pct = fourth_pct;
int penalties;
cin >> penalties;
ptr[i].teams[j].penalties = penalties;
int pen_yds;
cin >> pen_yds;
ptr[i].teams[j].pen_yds = pen_yds;
string top_per_game;
cin >> top_per_game;
strcpy(ptr[i].teams[j].top_per_game, top_per_game.c_str());
int fum;
cin >> fum;
ptr[i].teams[j].fum = fum;
int lost;
cin >> lost;
ptr[i].teams[j].lost = lost;
int to;
cin >> to;
ptr[i].teams[j].to = to;
}
}
int numberOfC;
cin >> numberOfC;
for (int i = 0; i < numberOfC; i++)
{
string command;
cin >> command;
if(command == "qsort") {
string command2;
cin >> command2;
int num = atoi(command2.c_str());
if (num >= 2010)
{
string year;
year = command2;
string field;
cin >> field;
string order;
cin >> order;
qSortYearFieldOrder(year, field, order, ptr, yearsToLoop);
}
}
So right here in (part of) the main I get all the inputs and then call a function using some of the inputs. 因此,在主体的一部分中,我得到了所有输入,然后使用一些输入来调用函数。 I am currently getting errors with the qSortYearFieldOrder(year, field, order, ptr, yearsToLoop).
我目前在使用qSortYearFieldOrder(year,field,order,ptr,yearsToLoop)时遇到错误。
void qSortYearFieldOrder(string year, string field, string order, annual_stats* ptr, int amountYears) {
int yearIndex = 0;
if (amountYears == 1) {
yearIndex == 0;
}
else {
if (year == "2010") {
yearIndex = 0;
}
else if (year == "2011") {
yearIndex = 1;
}
else if (year == "2012") {
yearIndex = 2;
}
else if (year == "2013") {
yearIndex = 3;
}
else if (year == "2014") {
yearIndex = 4;
}
else if (year == "2015") {
yearIndex = 5;
}
}
if (field == "team_name") {
if (order == "decr") {
cout << "\n\nDecreasing Order" << endl;
for (int i = 0; i < NO_TEAMS; i++) {
cout << ptr[yearIndex].teams[i].team_name;
}
}
else if (order == "incr") {
cout << "\n\nIncreasing Order" << endl;
for (int i = 0; i < NO_TEAMS; i++) {
cout << ptr[yearIndex].teams[NO_TEAMS - 1 - i].team_name;
}
}
}
else if (field == "games") {
if (order == "decr") {
quicksortGames(ptr, 0, NO_TEAMS - 1, yearIndex, order);
cout << "TEAM" << "\t\t" << "Number Of Games Decreasing";
for (int i = 0; i < NO_TEAMS; i++) {
cout << ptr[yearIndex].teams[i].team_name << " " << ptr[yearIndex].teams[NO_TEAMS - 1 - i].games;
}
}
else if (order == "incr") {
quicksortGames(ptr, 0, NO_TEAMS - 1, yearIndex, order);
cout << "TEAM" << "\t\t" << "Number Of Games Increasing";
for (int i = 0; i < NO_TEAMS; i++) {
cout << ptr[yearIndex].teams[NO_TEAMS - 1 - i].team_name << " " << ptr[yearIndex].teams[i].games;
}
}
}
Then in this function, I am sorting the code based on the field it is in and in incrementing/decrementing order. 然后在此函数中,我将根据代码所在的字段并按递增/递减顺序对代码进行排序。
void quicksortGames(annual_stats* pointer, int firstIndex, int lastIndex, int yearIndex, string order)
{
//declaring index variables
int pivotIndex, temp, index1, index2;
if(firstIndex < lastIndex)
{
//assigning first element index as pivot element
pivotIndex = pointer[yearIndex].teams[firstIndex].games;
index1 = pointer[yearIndex].teams[firstIndex].games;
index2 = pointer[yearIndex].teams[lastIndex].games;
//Sorting in Ascending order with quick sort
while(index1 < index2)
{
while(pointer[yearIndex].teams[index1].games <= pointer[yearIndex].teams[pivotIndex].games && index1 < lastIndex)
{
index1++;
}
while(pointer[yearIndex].teams[index2].games <= pointer[yearIndex].teams[pivotIndex].games)
{
index2--;
}
if(index1<index2)
{
//Swapping opertation
temp = pointer[yearIndex].teams[index1].games;
pointer[yearIndex].teams[index1].games = pointer[yearIndex].teams[index2].games;
pointer[yearIndex].teams[index2].games = temp;
}
}
//At the end of first iteration, swap pivot element with index2 element
temp = pointer[yearIndex].teams[pivotIndex].games;
pointer[yearIndex].teams[pivotIndex].games = pointer[yearIndex].teams[index2].games;
pointer[yearIndex].teams[index2].games = temp;
//Recursive call for quick sort, with partiontioning
quicksortGames(pointer, firstIndex, index2-1, yearIndex, order);
quicksortGames(pointer, index2+1, lastIndex, yearIndex, order);
}
}
This function serves to quick sort the games. 此功能用于对游戏进行快速排序。 I made it separately because quick sort is recursive and thus I can't quick sort inside the previous function.
我分开做是因为快速排序是递归的,因此我无法在以前的函数中进行快速排序。 I got the quick sort from this website: http://www.cprogramto.com/c-program-quick-sort/ .
我从以下网站获得了快速排序: http : //www.cprogramto.com/c-program-quick-sort/ 。
So basically, i'm trying to get all the inputs, stick them inside a function that sorts by field/order, and then specifically call the quick sort for the field. 因此,基本上,我试图获取所有输入,将它们放置在按字段/顺序排序的函数中,然后专门调用该字段的快速排序。
The code compiles but I am currently receiving a segmentation fault 11 error whenever I attempt to run the code with something along the lines of qsort 2015 games decr, etc. When I omit the qsort, my code runs and works for the other sorting algorithms (not shown here) so I am sure the error is within quick sort. 代码可以编译,但是当我尝试使用类似qsort 2015 games decr等的代码运行代码时,我目前收到一个细分错误11错误。当我省略qsort时,我的代码将运行并适用于其他排序算法(此处未显示),因此我确定该错误属于快速排序。 Will someone please help me see where exactly my error is?
有人可以帮我看看我的错误在哪里吗?
Consider: 考虑:
pivotIndex = pointer[yearIndex].teams[firstIndex].games;
index1 = pointer[yearIndex].teams[firstIndex].games;
index2 = pointer[yearIndex].teams[lastIndex].games;
...
while(pointer[yearIndex].teams[index1].games <= pointer[yearIndex].teams[pivotIndex].games && index1 < lastIndex)
You set the array index (index1, index2) to the number of games . 您将数组索引 (index1,index2)设置为游戏数 。
That's not guaranteed to be less than the # of elements in the teams array. 这不能保证小于teams数组中的元素数。
So you wind up accessing the teams array out of bounds == segfault. 因此,您最终将访问团队数组== segfault。
More Info: Compare your code to the site you got the algorithm from: 更多信息:将代码与从中获得算法的站点进行比较:
...
index2 = lastIndex;
//Sorting in Ascending order with quick sort
while(index1 < index2)
{
while(array[index1] <= array[pivotIndex] && index1 < lastIndex)
{
index1++;
....
Index is the position in the array, where array[index] is the value . Index是数组中的位置,其中array [index]是value 。 In your case, you are doing the comparison in the (inner) while loop correctly:
在您的情况下,您正在正确地在(内部)while循环中进行比较:
while(pointer[yearIndex].teams[index1].games <= pointer[yearIndex].teams[pivotIndex].games && index1 < lastIndex)
but you set the indexes incorrectly: 但是索引设置错误:
index1 = pointer[yearIndex].teams[firstIndex].games;
To make it more concrete, suppose there were 10 teams, but the first team (team #0) played 1000 games. 为了更加具体,假设有10支球队,但是第一支球队(0号球队)打了1000场比赛。 Then your code does this:
然后您的代码执行此操作:
index1 = pointer[yearIndex].teams[0].games; // index1=1000
while(pointer[yearIndex].teams[1000].games <=
pointer[yearIndex].teams[1000].games && 1000 < 9)
The problem is teams[1000] isn't valid if there are only 10 teams and when you access an array out of bounds like this in C, you get a segfault (if you're lucky) or corrupt memory and/or a security bug (if you're unlucky). 问题是如果只有10个团队,并且team [1000]无效,并且当您在C中这样访问数组时,您会遇到段错误(如果幸运的话)或内存和/或安全性受到破坏。错误(如果您不走运)。
Also, the suggestion made in comments to learn a source debugger (GDB, or whatever - depending on your platform) is critical to learning C. 另外,评论中提出的学习源调试器(GDB或其他任何东西-取决于您的平台)的建议对于学习C至关重要。
声明:本站的技术帖子网页,遵循CC BY-SA 4.0协议,如果您需要转载,请注明本站网址或者原文地址。任何问题请咨询:yoyou2525@163.com.