检查数组中是否包含非数字字符

Question

I am trying to create a function that will check an array for non-numeric characters. I'm sure there is a way with existing functions, but I was hoping to make a clean function.

This is what I have:

Public Function ContainsAllNumbers(Text() As Variant) As Boolean

    For Each element In Text

        If Not IsNumeric(element) Then

            ContainsAllNumbers = False

        End If

    Next

End Function

The arguments I want it to take would be something like 11013688 or K03778 or 9005110-4400. I need to know if these strings contain something that is not a number.

Answer 1

I assume you want a function that takes an array of strings and checks them for nun-numeric values. Then your question would be, why your function always returns False .

The default value of a Boolean is false so you need to set ContainsAllNumbers = True at the beginning of the function.

I also recommend using Option Explicit so you don't forget to Dim your variables.

Answer 2

Here is a (debugged) function which takes a string input and returns True if and only if all of the characters in the string are digits. This is (perhaps) what you are trying to do:

Function AllDigits(s As String) As Boolean
    Dim i As Long
    For i = 1 To Len(s)
        If Not IsNumeric(Mid(s, i, 1)) Then
            AllDigits = False
            Exit Function
        End If
    Next i
    AllDigits = True
End Function

Answer 3

Convert the characters to their ascii code and check each of them. You can Look up an ascii table to find out the specific values for certain characters.

As an example I just copied this from one of my macros. It checks for non-alphanumeric values in the input string str:

invalidCharacter = false
For pos = 1 To Len(str) 
Select Case Asc(Mid(str, pos, 1)) 'ascii value of character at str(pos)
        Case 48 To 57, 65 To 90, 97 To 122 '0-9,a-z,A-Z
            'nothing
        Case Else
            invalidCharacter = True
    End Select
Next pos
If invalidCharacter Then
    MsgBox "only numbers or letters may be used"
End If