Java Swing组件初始化

Question

Is it a good practice to put the initialisation code of a component in a method if it is more than just setting its colour, size and text?

// frame initialisation
public void init()
{
    .....

    sectors = new JSlider(10,50,12);
    initSlider();

    .....
}

public void initSlider()
{
    sectors.setMinorTickSpacing(1);
    sectors.setMajorTickSpacing(5);
    sectors.setSnapToTicks(true);
    sectors.setPaintLabels(true);
    sectors.setPaintTicks(true);
}

Answer 1

Yes it would be better and it would also make it easier to manage and read the code. This is what i think but at the end of the day it is up to the style of the programmer.

Answer 2

There is no harm in doing this, however, I would recommend you to move the initialisation into its own separate class to have a clean separation of concern.

class MySlider extends JSlider{
    public MySlider(){
       super();
       //init statements here
    }
}

Then in your frame/main class

public void init()
{
    .....
    sectors = new MySlider(10,50,12);
    .....
}