如果未遵守声明

Question

in my Unity project I have a script attached to a couple of prefabs. Every few seconds a random prefab is spawned. This is a part of my attached script:

private void OnCollisionEnter2D(Collision2D collision)
{
    if (collision.transform.CompareTag("ground"))
    {
        if (transform.gameObject.name == "FallingKeule(Clone)") 
        {
            Destroy(transform.gameObject);
        }
        if (transform.gameObject.name == "FallingHeart(Clone)")
        {
            Destroy(transform.gameObject);
        }
        if (transform.gameObject.name == "FallingCup(Clone)")
        {
            Destroy(transform.gameObject);
        }
        else
        {
            print("You lost a life!");
            Player.GetComponent<Colliding>().LostLife();
            Destroy(transform.gameObject);
        }               
    }
}

If a GameObject is spawned by random and it hit's the ground, and it is a "FallingKeule(Clone)" --> "(Clone)" because the prefab is cloned by it's initalisation the Code from

if (transform.gameObject.name == "FallingKeule(Clone)") 

isn't be done! The else code is been done:

else
{
    print("You lost a life!");
    Player.GetComponent<Colliding>().LostLife();
    Destroy(transform.gameObject);
}

Answer 1

You should use else if statement:

if (transform.gameObject.name == "FallingKeule(Clone)") 
{
    Destroy(transform.gameObject);
}
else if (transform.gameObject.name == "FallingHeart(Clone)")
{
    Destroy(transform.gameObject);
}
else if (transform.gameObject.name == "FallingCup(Clone)")
{
    Destroy(transform.gameObject);
}
else
{
    print("You lost a life!");
    Player.GetComponent<Colliding>().Destroy(transform.gameObject);
}

or much better:

var gameObjectName = transform.gameObject.name;
if(gameObjectName == "FallingKeule(Clone)" || gameObjectName == "FallingHeart(Clone)" || gameObjectName == "FallingCup(Clone)")
{
    Destroy(transform.gameObject);
}
else
{
    print("You lost a life!");
    Player.GetComponent<Colliding>().Destroy(transform.gameObject);
}

or even:

string[] dObjects = new string[] { "FallingKeule(Clone)", "FallingHeart(Clone)", "FallingCup(Clone)" };

private void OnCollisionEnter2D(Collision2D collision)
{
    if (collision.transform.CompareTag("ground"))
    {
        if(dObjects.Contains(transform.gameObject.name))
        {
            Destroy(transform.gameObject);
        }
        else
        {
            print("You lost a life!");
            Player.GetComponent<Colliding>().Destroy(transform.gameObject);
        }
    }
}