使用While循环列出索引超出范围

Question

This is my first time posting and I am a bit of newbie so please excuse any errors in my question. I have to create a function that uses the While loop and takes in a list of numbers and adds each number to a new list until the a specific number is reached. For example - I want each number in a list to be added until the number 5 is reached in the list. If the number 5 is not in the list, then I would get the entire list as is. The issue I am having is with this last part. My current code, posted below, can give me a new list of numbers that stops at the number 5 but I get the "List index out of range" error when the number 5 is not included in the list. I am sure its something small that I am not factoring in. Any help or guidance on what I am doing wrong would be greatly appreciated.

def sublist(x):
    i = 0
    num_list = []
    while x[i] != 5:
        num_list.append(x[i])
        i = i + 1
    return num_list

print(sublist([1, 2, 5, 7])) #works fine
print(sublist([1, 2, 7, 9])) #list index out of range error

Answer 1

As others have pointed out, it is best to use a for loop when you already know the number loops you need (eg: len(x) in your case).

If you still really want to use a while loop instead, you will need to check every loop to see if you have checked every item in the old list, and exit the loop if you do. Here's what your code could look like if you're using a while loop:

def sublist(x):
    i = 0
    num_list = []
    original_length = len(x)
    while i < original_length and x[i] != 5:
        num_list.append(x[i])
        i = i + 1
    return num_list

print(sublist([1, 2, 5, 7])) #works fine
print(sublist([1, 2, 7, 9])) #now also works fine

EDIT: I originally had the check for i < original_length inside the loop, I've changed it to be inside the while condition. BUT BE CAREFUL because the check MUST come before x[i] != 5 . What I mean is that using this will work:

while i < original_length and x[i] != 5:

But this will not:

while x[i] != 5 and i < original_length:

Answer 2

This should do the trick. If n (5 in your example) is in the list x it will take the list until that point. Else, it will take the whole list. This isn't the most pythonic option, though, probably someone knows a better way.

def sublist(x, n):
    num_list=[]
    if n in x:
        for i in x:
            while i!=n:
                num_list.append(i)
    else:
        num_list=x
    return num_list

Answer 3

Your loop will not stop if there is no 5 in the list, so the index i will be equal to the length of x (length of x is out of range) in the iteration when the error happens.

When looping with python, it's better to use for in loops:

def sublist(x):
  num_list = []
  for n in x:
    if n != 5:
      num_list.append(n)
    else:
      break
  return num_list

print(sublist([1, 2, 5, 7])) # [1, 2]
print(sublist([1, 2, 7, 9])) # [1, 2, 7, 9]

Answer 4

Try this

def sublist(x):
    x.sort() 
    limit_num = 5
    if limit_num not in x:return x
    return x[:x.index(limit_num)]

print(sublist([1, 2, 5, 7]))
print(sublist([1, 2, 7, 9])) 

Result:[1, 2]
       [1, 2, 7, 9]