这段代码可以更简单吗？ 哪个代码看起来更好？ [反向循环]

Question

Can you make code 1) even more simple than it is?

Or maybe there is some better approach?

I wrote this two really simple code just to visualize the differences.

From my perspective, code 1) looks to be more clear then 2), especially when implementing more stuff in loop, for example list of dicts.

1) For with zip

shopping_list =['bananas', 'car', 'rum', 'cat', 'meat', 'jelly']
for i, item in zip(range(len(shopping_list)-2, -1, -1), shopping_list):
    print(i, item)
    if item == 'cat':
        shopping_list.pop(i)

print()

2) just for

shopping_list =['bananas', 'car', 'rum', 'cat', 'meat', 'jelly']
for i in range(len(shopping_list)-1, -1, -1):
    print(i, shopping_list[i])
    if shopping_list[i] == 'cat':
        shopping_list.pop(i)

Result of loop is:

['bananas', 'rum', 'meat', 'jelly']

Answer 1

You don't need to modify the original list to remove words which don't satisfy the condition, which you seem to be doing in the first two approaches.

Instead, you can use filter to remove elements based on the condition word != 'cat'

shopping_list =['bananas', 'car', 'rum', 'cat', 'meat', 'jelly']
print(list(filter(lambda x: x != 'cat', shopping_list)))

The output will be

['bananas', 'car', 'rum', 'meat', 'jelly']

Answer 2

Your solutions are not good, because unecessary complexity and because you modify a list while looping on it (which can be tricky).

Use either list comprehensions (as mentioned in comments):

shopping_list = [w for w in shopping_list if w != 'cat']

Or the filter method:

shopping_list  = list(filter(lambda x: x != 'cat', shopping_list))