[英]Reading array from file not giving correct values?
Currently working on a project that must be completed by this Thursday night PST.目前正在开展一个必须在太平洋标准时间周四晚上完成的项目。 For a quick summary, the program must be menu based and allow the user to create an array of long doubles (user set number of rows/columns and all array values) and have it save to a file (user set name).
为了快速总结,程序必须基于菜单,并允许用户创建一个长双精度数组(用户设置的行/列数和所有数组值)并将其保存到文件(用户集名称)。 It must also allow the user to read a file into an array of long doubles and print it to the program, then allow the user to select a column to sort and save the sorted array into another file, then finally allow the user to search for a value in a file (where the program must know if the columns are sorted or unsorted and use the appropriate search algorithm).
它还必须允许用户将一个文件读入一个长双精度数组并将其打印到程序中,然后允许用户选择一列进行排序并将排序后的数组保存到另一个文件中,最后允许用户搜索文件中的一个值(程序必须知道列是已排序还是未排序并使用适当的搜索算法)。
I have not completed CHOICE_4 in the menu because of the issues with CHOICE_2 and CHOICE_3 functions.由于 CHOICE_2 和 CHOICE_3 功能的问题,我尚未完成菜单中的 CHOICE_4。 Here is my source code for the entire project:
这是我整个项目的源代码:
#include <iostream>
#include <string>
#include <iomanip>
#include <cstdlib>
#include <fstream>
#include <vector>
using namespace std;
//Function prototypes required for project
void displayMenu(int &); //Menu function
int unsortedFile(string, int, int); //Function for menu choice 1
int printFile(string, int, int); //Function for menu choice 2
int sortFile(string, int, int); //Function for menu choice 3
int main()
{
int choice; //Menu choice
do
{
displayMenu(choice);
}
while (choice > 0 && choice <= 4);
return 0;
}
void displayMenu(int &c)
{
//Constants for menu choices
const int CHOICE_1 = 1,
CHOICE_2 = 2,
CHOICE_3 = 3,
CHOICE_4 = 4,
QUIT_CHOICE = 0;
string filenameU, //unsorted
filenameP, //printed
filenameS, //to be sorted
filenameSOut; //sorted data
int SIZE1, //Array dimensions
SIZE2; //Array dimensions
cout << "-------------------------" << endl;
cout << "\tMENU" << endl;
cout << "-------------------------" << endl;
cout << "1. Create a custom array file." << endl;
cout << "2. Print an array from a file." << endl;
cout << "3. Sort an array from a file." << endl;
cout << "4. Search an array from a file." << endl;
cout << "0. Exit program." << endl;
cout << "-------------------------" << endl;
cout << "Enter your choice from above: ";
cin >> c;
cout << endl;
switch(c)
{
case CHOICE_1:
cout << "Enter the name of the file you want to write: ";
cin.ignore(100, '\n');
getline(cin, filenameU, '\n');
do
{
cout << endl;
cout << "Enter the amount of rows you want in your array between 2 and 10: ";
cin >> SIZE1;
} while (SIZE1 < 2 || SIZE1 > 10);
do
{
cout << endl;
cout << "Enter the amount of columns you want in your array between 2 and 10: ";
cin >> SIZE2;
} while (SIZE2 < 2 || SIZE2 > 10);
unsortedFile(filenameU, SIZE1, SIZE2);
break;
case CHOICE_2:
cout << "Enter the name of the file you want to print: ";
cin.ignore(100, '\n');
getline(cin, filenameP, '\n');
printFile(filenameP, SIZE1, SIZE2);
break;
case CHOICE_3:
cout << "Enter the name of the file you want to sort: ";
cin.ignore(100, '\n');
getline(cin, filenameS, '\n');
sortFile(filenameS, SIZE1, SIZE2);
break;
case CHOICE_4:
break;
case QUIT_CHOICE:
cout << "Exiting program." << endl;
break;
default:
cout << "The valid entries are 1-4 or 0 to exit program.";
}
}
int unsortedFile(string filenameU, int SIZE1, int SIZE2)
{
long double arr[SIZE1][SIZE2]; //Array for user definition
ofstream outputFileU;
outputFileU.open(filenameU.c_str());
//Get data for file output
if (outputFileU)
{
//Get user input for array
cout << "Enter numbers into the array." << endl;
for (int i = 0; i < SIZE1; i++)
{
for (int j = 0; j < SIZE2; j++)
{
cout << "Enter element [" << i << "] [" << j << "]: ";
cin >> arr[i][j];
outputFileU << arr[i][j] << " ";
}
outputFileU << endl;
}
}
else
{
cout << "File could not be opened for writing..." << endl;
return 1;
}
//Close the file
outputFileU.close();
cout << "-------------------------" << endl;
cout << "File named: " << filenameU << " written." << endl;
cout << endl;
}
int printFile(string filenameP, int SIZE1, int SIZE2)
{
ifstream inputFileP;
inputFileP.open(filenameP.c_str());
if (inputFileP.is_open())
{
long double pArr[SIZE1][SIZE2];
inputFileP >> SIZE1 >> SIZE2;
while (inputFileP.good())
{
for (int i = 0; i < SIZE1; i++) //steps through rows
{
for (int j = 0; j < SIZE2; j++) //steps through columns
{
inputFileP >> pArr[i][j]; //reads data at position i, j
cout << pArr[i][j] << " "; //prints value at position i, j
}
cout << endl;
}
}
inputFileP.close();
cout << "-------------------------" << endl;
cout << "File named: " << filenameP << " printed." << endl;
cout << endl;
}
else
{
cout << "File could not be opened for printing..." << endl;
return 1;
}
}
int sortFile(string filenameS, int SIZE1, int SIZE2)
{
int key;
ifstream inputFileS;
inputFileS.open(filenameS.c_str());
if(inputFileS)
{
inputFileS >> SIZE1;
inputFileS >> SIZE2;
long double temp[SIZE1];
long double data[SIZE1][SIZE2];
for (int i = 0; i < SIZE1; i++)
{
for (int j = 0; j < SIZE2; j++)
{
inputFileS >> data[i][j];
}
}
cout << "Enter which column you want to sort: ";
cin >> key;
key--;
for (int i = 0; i < SIZE1; i++)
{
for (int j = 0; j < SIZE2; j++)
{
if (data[i][key] > data[j][key])
{
for (int t = 0; t < SIZE1; t++)
{
temp[t] = data[i][t];
}
for (int t = 0; t < SIZE1; t++)
{
data[i][t] = data[j][t];
}
for (int t = 0; t < SIZE1; t++)
{
data[j][t] = temp[t];
}
}
}
}
string filenameSOut;
cout << "\nEnter file name to save sorted data: ";
cin.ignore(100, '\n');
getline(cin, filenameSOut, '\n');
ofstream outputFileS;
outputFileS.open(filenameSOut.c_str());
outputFileS << SIZE1 << " " << SIZE2 << endl;
for (int i = 0; i < SIZE1; i++)
{
for (int j = 0; j < SIZE2; j++)
{
outputFileS << data[i][j];
}
outputFileS << endl;
}
outputFileS.close();
cout << "-------------------------" << endl;
cout << "File named: " << filenameSOut << " sorted." << endl;
cout << endl;
}
else
{
cout << "File could not be opened for sorting...";
return 1;
}
}
My output currently reads like so (using some sample inputs):我的输出目前是这样的(使用一些示例输入):
-------------------------
MENU
-------------------------
1. Create a custom array file.
2. Print an array from a file.
3. Sort an array from a file.
4. Search an array from a file.
0. Exit program.
-------------------------
Enter your choice from above: 1
Enter the name of the file you want to write: Yeetus
Enter the amount of rows you want in your array between 2 and 10: 3
Enter the amount of columns you want in your array between 2 and 10: 4
Enter numbers into the array.
Enter element [0] [0]: 5
Enter element [0] [1]: 3
Enter element [0] [2]: 8
Enter element [0] [3]: 9
Enter element [1] [0]: 2
Enter element [1] [1]: 1
Enter element [1] [2]: 0
Enter element [1] [3]: 3
Enter element [2] [0]: 5
Enter element [2] [1]: 7
Enter element [2] [2]: 4
Enter element [2] [3]: 4
-------------------------
File named: Yeetus written.
-------------------------
MENU
-------------------------
1. Create a custom array file.
2. Print an array from a file.
3. Sort an array from a file.
4. Search an array from a file.
0. Exit program.
-------------------------
Enter your choice from above: 2
Enter the name of the file you want to print: Yeetus
8 9 2
1 0 3
5 7 4
4 1.45808e-4950 1.45808e-4950
1.45808e-4950 1.74779e-4944 4.70418e+1991
-------------------------
File named: Yeetus printed.
-------------------------
MENU
-------------------------
1. Create a custom array file.
2. Print an array from a file.
3. Sort an array from a file.
4. Search an array from a file.
0. Exit program.
-------------------------
Enter your choice from above: 3
Enter the name of the file you want to sort: Yeetus
Enter which column you want to sort: 3
Enter file name to save sorted data: YeetusSorted
-------------------------
File named: YeetusSorted sorted.
-------------------------
MENU
-------------------------
1. Create a custom array file.
2. Print an array from a file.
3. Sort an array from a file.
4. Search an array from a file.
0. Exit program.
-------------------------
Enter your choice from above: 0
Exiting program.
--------------------------------
Process exited after 58.35 seconds with return value 0
Press any key to continue . . .
The first function unsortedFile
works perfectly minus the requirement that it must also include UNSORTED in the first line, followed by ROWS: and COLUMNS: in the second and third line, respectively.第一个函数
unsortedFile
工作完美,但它必须在第一行中包含 UNSORTED ,然后分别在第二行和第三行中包含 ROWS: 和 COLUMNS: 。 With just numbers, it prints like so:只有数字,它打印如下:
5 3 8 9
2 1 0 3
5 7 4 4
The second function seems to skip the first two numbers in the file, print the rest, then print a bunch of garbage.第二个函数似乎跳过文件中的前两个数字,打印其余部分,然后打印一堆垃圾。
The third function gives the following file with the example data I've provided:第三个函数提供了以下文件,其中包含我提供的示例数据:
5 3
894
103
572
4-2.71616e-11730
1.56264e-48671.68249e-2119-inf
Not...entirely sure why this is happening.不......完全确定为什么会发生这种情况。 If I can get a grasp on reading the data from the file correctly as to get the real numbers, I can finish this program easily with the sorting and searching algorithms (hopefully).
如果我能够正确地从文件中读取数据以获得实数,我可以使用排序和搜索算法轻松完成这个程序(希望如此)。 For now, I'm stuck.
现在,我被困住了。 If anyone could help me fix the second and third functions to read/print and sort accurate numbers, as well as let me know how to make the file look like so without it breaking the other functions:
如果有人可以帮助我修复第二个和第三个功能以读取/打印和排序准确的数字,并让我知道如何使文件看起来像这样而不破坏其他功能:
UNSORTED
Rows: 3
Columns: 4
5 3 8 9
2 1 0 3
5 7 4 4
For reference: the class this is for is the introductory course for C++.供参考:这门课是 C++ 的入门课程。 We are only supposed to use what I've provided here today.
我们应该只使用我今天在这里提供的内容。 Vectors and pointers are also allowed, but I am trying to avoid them as I don't have a full understanding of how to use them, nor do I have time to learn how to use them for this project.
向量和指针也是允许的,但我试图避免它们,因为我没有完全了解如何使用它们,也没有时间学习如何在这个项目中使用它们。
Focusing on printFile
for now: The first thing your function does is现在专注于
printFile
:您的函数所做的第一件事是
inputFileP >> SIZE1 >> SIZE2;
but there are a number of problems:但是有很多问题:
unsortedFile
function does not write this header .unsortedFile
函数不会写入此标头。 You are effectively treating the first two elements of the first row as the sizes to read.SIZE1
and SIZE2
parameters you passed as an argument.SIZE1
和SIZE2
参数。 Why even pass these if you're going to read them from the file directly?SIZE1
and SIZE2
provided as argument.SIZE1
和SIZE2
分配数组后,您从文件中读取大小。 So you effectively allocate memory for an array of 3x4, and then write into it as if it were a 5x3 matrix.因此,您可以有效地为 3x4 数组分配内存,然后将其写入其中,就好像它是一个 5x3 矩阵一样。 This will give fireworks.
这将产生烟花。
Final note: your top-level menu assumes the user always goes through option 1 to set SIZE1
and SIZE2
.最后一点:您的顶级菜单假设用户总是通过选项 1 来设置
SIZE1
和SIZE2
。 You should either remove these arguments from the functions that do not use them, or explicitly set them.您应该从不使用它们的函数中删除这些参数,或者显式设置它们。 From what I see here it is best if you removed these parameters from the function calls in options 2–4.
从我在这里看到的情况来看,最好从选项 2-4 中的函数调用中删除这些参数。
声明:本站的技术帖子网页,遵循CC BY-SA 4.0协议,如果您需要转载,请注明本站网址或者原文地址。任何问题请咨询:yoyou2525@163.com.