无法将文件从文件夹复制到不同的文件夹

Question

I'm trying to loop over the files witch start with 'R008' in the directory and copy them to the different folders (which are all in the same directory).

import shutil
import os
source = 'D:\\source_folder\\'
dest1 = 'D:\\destination_folder\\' 

folder_name = input("What day of the month? ")
folder_path = (dest1 + folder_name)
i = 1

files = os.listdir(source)

for file in files:
    if file.startswith('R008'):
        if not os.path.exists(folder_path):
            os.makedirs(folder_path)
            shutil.copy(os.path.join(source, file), folder_path)

        if os.path.exists(folder_path):
            os.makedirs(folder_path + "_" + str(i))
            shutil.copy(os.path.join(source, file), folder_path + "_" + str(i))
            i += 1

My problem is the first file is always copied twice. 5 folders are created for 4 files 1 . And I don't understend why

Answer 1

You have two independent tests, and the body of the first if makes (by creating folder_path ) the condition for the second if ( folder_path exists) true. So you end up performing both copies. If you want to only copy to the root path, and not also copy to the extended path, just make the second if into an else tied to the original if , eg:

    if not os.path.exists(folder_path):
        os.makedirs(folder_path)
        shutil.copy(os.path.join(source, file), folder_path)
    else:  # Could be elif os.path.exists(folder_path), but you literally just verified it doesn't exist
        os.makedirs(folder_path + "_" + str(i))
        shutil.copy(os.path.join(source, file), folder_path + "_" + str(i))
        i += 1