创建对象数组； 最好的方法是什么？

Question

Good afternoon.

I am attempting to make a small game inspired by Among Us. The game will feature two bandits if there are 7 or more players, and one bandit if the player count is 6 or less.

I have run into a problem though, so I am attempting to create multiple constructors, here is how I imagine the layout to be.

Console -> Input names separated by comma -> String[] names -> newPlayer Constructor

The newPlayer constructor will then determine the number of players, and sort them into their respective constructor, using Math.random to determine the bandits.

Bandit route newPlayer Constructor -> Bandit Constructor -> Player Constructor

Cowboy route newPlayer Constructor -> Bandit Constructor -> Player Constructor

The problem is that after the data is given to the Player constructor, I'd like to create an array of type Player[], so I can easily access the data within, without creating invidual Player variables, and then making this array accessible to the rest of the classes within the package. I'm looking for the most concise way to do it.

Although I feel like this may not require code for context, I'll provide it in case it helps answer my question.

Bandit Class

    package Sorting;

public class Bandit {
    private int playerID;
    private String playerName;
public Bandit(int ID, String name) {
    this.playerName = name;
    this.playerID = ID;
    Player newBandit = new Player(playerID,true,playerName);
}
}

Cowboy Class

package Sorting;

public class Cowboy {

    private int playerID;
    private String playerName;
    
    public Cowboy(int ID, String name) {
        this.playerID = ID;
        this.playerName = name;
        Player newCowboy = new Player(this.playerID,false,this.playerName);
    }
    
}

newPlayer Class

package Sorting;

public class NewPlayer {
    private String name;
    private int playerID;
    private int impostor1, impostor2;
    
    NewPlayer (int ID, String name, int playerCount) {
        if(playerCount<=6) {int impostor1 = (int)Math.random()*playerCount;
        if(impostor1==this.playerID) {
        Bandit bandit1 = new Bandit (this.playerID, this.name);}
        }
        else {
            impostor1 = (int)Math.random()*playerCount;
            impostor2 = (int)Math.random()*playerCount;
            while (impostor1 == impostor2) {
                impostor2 = (int)Math.random()*playerCount;
            }
            if(impostor1==this.playerID) {
            Bandit bandit1 = new Bandit (this.playerID, this.name);}
            if(impostor2==this.playerID) {
            Bandit bandit2 = new Bandit (this.playerID, this.name);}
        }
        for(int i=0;i<playerCount;i++) {
            if ((this.playerID!=impostor1)&&(this.playerID!=impostor2)) {
                Cowboy newCowboy = new Cowboy(this.playerID,this.name);
            }
        }
        }
        
    }

Player Class

package Sorting;
public class Player {
    
    public int playerCount;
    private int playerID;
    private boolean playerBandit;
    private String playerName;
    
    public Player(int id, boolean bandit, String name) {
        this.playerID = id;
        this.playerBandit = bandit;
        this.playerName = name;
        playerCount++;
    }
    public String getPlayerName() {return this.playerName;}
    public boolean getBandit() {return this.playerBandit;}
    public int getPlayerID() {return this.playerID;}
}

I do not think the Tester class would be required to answer this question, but I'll provide it. Be aware, this part is not finished.

package Sorting;
import java.util.*;
public class Tester {
    private static int playerCount;
    public static void main(String[] args) {
        
        Scanner input = new Scanner(System.in);
        System.out.println("Please enter player names, separated by a comma: ");
        String nameList[] = input.nextLine().split(",");
        playerCount = nameList.length;
        Assigner.Assignment(nameList);
    }
    public int getPlayerCount() {return playerCount;}
}

I'd like the array of Players to be created within the tester class, and accessible to the rest of the classes within the package.

What is the best way to do this?

Answer 1

"I'd like the array of Players to be created within the tester class" : I would suggest using List interface instead of native java array (much easier to use). Something like this: List<Player> players = new ArrayList<>() and you can use players.add( /*player*/ ) and players.get(/*idx*/) to add and retrieve.

"accessible to the rest of the classes within the package" : a default class property is accessible for classes within the same package. Like this: List<Player> players; or already initialized: List<Player> players = new ArrayList<>(); . Don't use any modifier like private , public or protected and it will mean this property is "default" access (within same package). See: https://docs.oracle.com/javase/tutorial/java/javaOO/accesscontrol.html