从C＃控制台应用程序杀死Java进程

Question

I posted about this a little while ago, but I resolved the other issue and ran into one more. I am about to deploy this program to 28 hosting machines so I want to make sure this is working before I do so.

I wrote a little c# NET application that is basically a wrapper for a Java application, when my app starts, the Java app starts, when my app closes, it closes, and so on.

Everything works properly except that when I close my application, the Java application continues to run. When I create the process, I store the Process var in a variable outside of the methods, and then use that when my application goes to shutdown. For whatever reason though it is not terminating the Java application.

class Program
{
    private static Process minecraftProcess;

    public static void LaunchMinecraft(String file, String memoryValue)
    {
        String memParams = "-Xmx" + memoryValue + "M" + " -Xms" + memoryValue + "M ";
        String args = memParams + "-jar " + file + " nogui";
        ProcessStartInfo processInfo = new ProcessStartInfo("java.exe", args);
        processInfo.CreateNoWindow = true;
        processInfo.UseShellExecute = false;

        try
        {
            //using (Process minecraftProcess = Process.Start(processInfo))
            using (minecraftProcess = Process.Start(processInfo))
            {
                minecraftProcess.WaitForExit();
            }
        }
        catch
        {
            // Log Error
        }
    }

    static void Main(string[] args)
    {
        Arguments CommandLine = new Arguments(args);

        // Hook ProcessExit Event
        AppDomain.CurrentDomain.ProcessExit += new EventHandler(Current_ProcessExit);

        if (CommandLine["file"] != null && CommandLine["memory"] != null)
        {
            // Launch the Application (Command Line Parameters)
            LaunchMinecraft(CommandLine["file"], CommandLine["memory"]);
        }
        else
        {
            // Launch the Application (Default Parameters)
            LaunchMinecraft("minecraft_server.jar", "1024");
        }
    }

    static void Current_ProcessExit(object sender, EventArgs e)
    {
        System.Threading.Thread.Sleep(10000);

        // If we have an active Minecraft Service, Shut it down
        if (minecraftProcess != null)
        {
            minecraftProcess.Kill();
        }
    }
}

Answer 1

You can't Sleep in a ProcessExit handler.

The documentation states:

The total execution time of all ProcessExit event handlers is limited, just as the total execution time of all finalizers is limited at process shutdown. The default is two seconds. An unmanaged host can change this execution time by calling the ICLRPolicyManager::SetTimeout method with the OPR_ProcessExit enumeration value.

Answer 2

没关系，我只是意识到minecraftProcess变量是静态的。

Answer 3

Don't know if you did not solve this issue by yourself but:

• You should be aware that there are Start methods for instances (returning bool) and static (returning a object).

• You should not use using with something other than using-local variables!

Just this should work fine:

minecraftProcess = Process.Start(processInfo)
minecraftProcess.WaitForExit();