while循环不向每个循环添加数据新创建的对象？ 在java中

Question

Hi everyone once again thanks for taking the time to look at my issue.

I am trying to create a program that keeps track of employees and the diffrent departments that they are working in.

The program first reads from a text file all the initial data to get the program going. The program then has a while loop within a while loop. The first loop will read the department details and then create the department

in then the next (inner) while loop it reads all the employees accosiated with this department,It then after reading the details of the employee creates the employee and adds it to the previously created department to say this is the department I work in.

after adding all the employees to the department, it then exits that inner loop and sends the department with the employees inside it to the mainDriver for storage. It does this for the remaining departments again adding their associated employees and so on.

The problem Is: it seems to create each department okay and add it to the mainDriver, but all the employees are added to the first department and the remaining department are left empty. Which is not the way it should work as their are several employees in each department.
Why is it not moving on to the next department as the new Department is instantiated??

Could I please have some help to see where I may be going wrong.

this is the code that read in the data.

 while  (index < numberOfDepartmentsToRead ) 
{
        String depName1    = inFile.nextLine();
        String location1     = inFile.nextLine();
        String numberOfEmps = inFile.nextLine();
        int    numberOfEmps1 = Integer.parseInt(numberOfEmps);
        Department newDepartment = new Department(depName1 , location1);

    while (i < numberOfEmps1 )
    {
        String fName     = inFile.nextLine();
        String lName     = inFile.nextLine();
        String gender    = inFile.nextLine();
        String address   = inFile.nextLine();
        String   payLevel  = inFile.nextLine(); 
        int dPayLevel = Integer.parseInt(payLevel);
        Employee employeesFromList = new Employee(randomIDno, fName, lName, gender, dPayLevel);
        newDepartment.setAddEmp(employeesFromList, randomIDno);
        i++;
    }

    i = 0;
    index++;
    MainDriver.setDepartmentToSystem(newDepartment);        
} 

the employee is passed to this method in the departments class

public static void setAddEmp(Employee theEmp, int idNumber)
{
    employeesInThisDepartment.add(theEmp);
    employeeMap.put(idNumber, theEmp);
}

the department is added to the mainDriver classes storage method which is this

public static void setDepartmentToSystem(Department theDepartment)
        {

            allDepartments.add(theDepartment);
        } 

Answer 1

public static void setAddEmp(Employee theEmp, int idNumber)

Why is it static ? Make it instance method.

Make employeesInThisDepartment instance variable instead of static .

Answer 2

You might want to check your use of static . It is difficult to know without seeing all your code but I wonder if setAddEmp should not be a static method.

Answer 3

Your employeesInThisDepartment is a static variable, whereas you need one per- Department .

Each Department should have its own instance, with an employees property, to which the department's employees are added. Similarly, the method to add an employee to the department should be an instance method, not static.

Answer 4

Binyomin, i think your inner while controller makes wrong...

while (i < numberOfEmps1 ){ i++; }

I think this loop will traverse all the employees in the file. Then the next iteration of the inner loop will return EOF...

Try posting your file structure..