[英]Resuming my app make it crash due to cursor management
I've got a lot of Cursor in my app and I'm trying to manage them clearly. 我的应用程序中有很多Cursor,因此我试图对其进行清晰的管理。 I did as it's explained in tutos : closing them at the end.
我按照tutos中的解释进行了操作:最后将它们关闭。 But, on my Nexus S with ICS, when I'm resuming my app, I got crash
但是,在带有ICS的Nexus S上,当我恢复我的应用时,我崩溃了
01-23 21:52:32.125: E/AndroidRuntime(14037): Caused by: android.database.StaleDataException: Attempted to access a cursor after it has been closed.
I saw some answers on the internet saying that I should use LoaderManager to manage them but I'm not sure it's adapted to my case. 我在网上看到一些答案,说我应该使用LoaderManager来管理它们,但是我不确定它是否适合我的情况。 This is my functions using cursor :
这是我使用光标的功能:
public static HashMap<String, Contact> getContacts(BaseActivity activity) {
HashMap<String, Contact> contactMap = new HashMap<String, Contact>();
ArrayList<String> allPhones =null;
try{
Log.d(Constants.LOGTAG,"=!=!=!=!=!=!=!=!=!=! GET CONTACTS (HashMap) =!=!=!=!=!=!=!=!=!=!=!=!=!=!");
// Run query
String thePhone;
int id;
Uri uri = ContactsContract.Contacts.CONTENT_URI;
String[] projection = new String[] {
ContactsContract.Contacts._ID,
ContactsContract.Contacts.DISPLAY_NAME,
ContactsContract.Contacts.HAS_PHONE_NUMBER };
Cursor cursor = activity.managedQuery(uri, projection, null, null, null);
//activity.startManagingCursor(cursor);
if (cursor.moveToFirst()) {
while (!cursor.isAfterLast()) {
id = cursor.getInt(0);
if (cursor.getInt(2) == 1) {
Contact c = new Contact(id, cursor.getString(1),null,getAllPhoneNumber(activity, id));
Contact c2 = new Contact(id, cursor.getString(1),null,getAllPhoneNumber(activity, id));
allPhones = c.getPhoneNumber();
for(String phone:allPhones){
thePhone = phone;
c2.getPhoneNumber().clear();
c2.setIndicatif("+33");
thePhone = thePhone.replaceAll(" ", "");
if(thePhone.startsWith("00")){//On vire le 0033
thePhone = thePhone.substring(4);
}
else if(thePhone.startsWith("+")){//On vire le +33
thePhone =thePhone.substring(3);
}
if(thePhone.startsWith("0")){
thePhone = thePhone.substring(1);
}
//c.getPhoneNumber().add(thePhone);
c2.getPhoneNumber().add(thePhone);
contactMap.put(thePhone,c2);
}
}
cursor.moveToNext();
}
}
cursor.close();
}catch (Exception e) {
e.printStackTrace();
}
Whosupp.setAdresseBookHM(contactMap);
return contactMap;
}
/**
* Obtains the contact list from the Adress Book for the currently selected account SORTED BY NAME
*
* @return a list of all contact.
*/
public static ArrayList<Contact> getContactsSortedByName(BaseActivity activity) {
ArrayList<Contact> contactList = new ArrayList<Contact>();
ArrayList<String> allPhones =null;
try{
Log.d(Constants.LOGTAG,"=!=!=!=!=!=!=!=!=!=! GET CONTACTS (ArrayList) =!=!=!=!=!=!=!=!=!=!=!=!=!=!");
// Run query
String thePhone;
Uri uri = ContactsContract.Contacts.CONTENT_URI;
String[] projection = new String[] {
ContactsContract.Contacts._ID,
ContactsContract.Contacts.DISPLAY_NAME,
ContactsContract.Contacts.HAS_PHONE_NUMBER };
String sortOrder = ContactsContract.Contacts.DISPLAY_NAME
+ " COLLATE LOCALIZED ASC";
Cursor cursor = activity.managedQuery(uri, projection, null, null, sortOrder);
//activity.startManagingCursor(cursor);
if (cursor.moveToFirst()) {
while (!cursor.isAfterLast()) {
int id = cursor.getInt(0);
if (cursor.getInt(2) == 1) {
Contact c = new Contact(id, cursor.getString(1),null,getAllPhoneNumber(activity, id));
allPhones = c.getPhoneNumber();
for(String phone:allPhones){
thePhone = phone;
c.getPhoneNumber().clear();
c.setIndicatif("+33");
thePhone = thePhone.replaceAll(" ", "");
if(thePhone.startsWith("00")){//On vire le 0033
thePhone = thePhone.substring(4);
}
else if(thePhone.startsWith("+")){//On vire le +33
thePhone =thePhone.substring(3);
}
if(thePhone.startsWith("0")){
thePhone = thePhone.substring(1);
}
//c.getPhoneNumber().add(thePhone);
contactList.add(c);
}
}
cursor.moveToNext();
}
}
cursor.close();
}catch (Exception e) {
e.printStackTrace();
}
return contactList;
}
/**
* Get the first phone number of a contact
*
* @param contactId
* the contact's id
* @return the first phone number of the contact !
*/
public static ArrayList<String> getFirstPhoneNumber(BaseActivity activity, int contactId) {
final String[] projection = new String[] { Phone.NUMBER };
ArrayList<String> number=new ArrayList<String>();
Cursor phone = activity.managedQuery(Phone.CONTENT_URI, projection,
Data.CONTACT_ID + "=?",
new String[] { String.valueOf(contactId) }, null);
//activity.startManagingCursor(phone);
if (phone.moveToFirst()) {
number.add(phone.getString(phone.getColumnIndex(Phone.NUMBER)));
}
phone.close();
return number;
}
/**
* Get all phone number of a contact
*
* @param contactId
* the contact's id
* @return a list of all phone number of the contact
*/
public static ArrayList<String> getAllPhoneNumber(BaseActivity activity, int contactId) {
final String[] projection = new String[] { Phone.NUMBER };
String number = "";
Cursor phone = activity.managedQuery(Phone.CONTENT_URI, projection,
Data.CONTACT_ID + "=?",
new String[] { String.valueOf(contactId) }, null);
//activity.startManagingCursor(phone);
ArrayList<String> phoneNumber = new ArrayList<String>();
if (phone.moveToFirst()) {
final int contactNumberColumnIndex = phone.getColumnIndex(Phone.NUMBER);
while (!phone.isAfterLast()) {
number = phone.getString(contactNumberColumnIndex);
if(number.contains("305875")) Log.d(Constants.LOGTAG,"I'm here "+number);
phoneNumber.add(number);
phone.moveToNext();
}
}
phone.close();
return phoneNumber;
}
As you can see, I've tried to use "startManagingCursor" but it's even worst... Does anyone be confronted to this and finally solved it ? 如您所见,我尝试使用“ startManagingCursor”,但更糟糕的是……有人面对这个问题并最终解决了吗? Should I use LoaderManager ?
我应该使用LoaderManager吗?
according to android documentation 根据android文档
Warning: Do not call close() on a cursor obtained using this method, because the activity will do that for you at the appropriate time.
警告:请勿在使用此方法获得的游标上调用close(),因为该活动将在适当的时候为您执行此操作。 However, if you call stopManagingCursor(Cursor) on a cursor from a managed query, the system will not automatically close the cursor and, in that case, you must call close().
但是,如果从托管查询的游标上调用stopManagingCursor(Cursor),则系统不会自动关闭游标,在这种情况下,必须调用close()。
so please try removing cursor.close();
所以请尝试删除
cursor.close();
in your code. 在您的代码中。
Write onResume()
like this: 像这样写
onResume()
:
@Override
protected void onResume() {
// TODO Auto-generated method stub
super.onResume();
if (!dbHelper.db.isOpen()) {
dbHelper.open();
}
cursor.requery();
}
I am looking into code and can't find where is onResume with opening/startmanaging/recreating the cursores. 我正在研究代码,无法通过打开/启动管理/重新创建游标找到onResume。 I would look for the error here.
我会在这里寻找错误。
您有两个选择使用活动方法startManagingCursor(...),或者只是停止尝试使用onResume()中关闭或为null的光标进行操作。
Here was the answer : 这是答案:
manageQuery just open up a MANAGED cursor (one such provided with StartManagingCursor). manageQuery只是打开一个MANAGED游标(StartManagingCursor随附的一个游标)。 Thus cursor do not need to be closed.
因此,游标不需要关闭。
But, since in our app we use more then 1 cursor, it'd be awful to use managed cursor, so we use "simple" cursors and close them after we are done. 但是,由于在我们的应用程序中,我们使用了1个以上的游标,因此使用托管游标会很糟糕,因此我们使用“简单”游标并在完成后将其关闭。 So we just had to do a simple Query instead of ManagedQuery...
所以我们只需要做一个简单的查询而不是ManagedQuery ...
声明:本站的技术帖子网页,遵循CC BY-SA 4.0协议,如果您需要转载,请注明本站网址或者原文地址。任何问题请咨询:yoyou2525@163.com.