检查ace是否存在以及点是否> 21

Question

In my blackjack program i have:

Card c = dealCard(deck); //deals the card
updatePoints(players[i], c); // calls updatePoints below. 

The updatePoints function looks like this:

public static void updatePoints(Player player,  Card c){

        int point = c.getValue();
        if(player.getPoints() + point >21 && (player.ace1 == 11 || player.ace2 == 11 || player.ace3 == 11 || player.ace4 == 11)){
            player.points -= 10;
            player.setPoints(point);
            if (player.ace1 == 11){
                player.ace1 = 1;
            }else if(player.ace2 == 11){
                player.ace2 = 1;
            }else if(player.ace3 == 11){
                player.ace3 = 1;
            }else if (player.ace4 == 11){
                player.ace4 = 1;
            }
        }
        if (point == 1){
            //default value for player.ace1 .. player.ace4 is 0


            if(player.ace1 == 0){
                player.ace1 = 11;
                player.setPoints(11);
            }else if (player.ace2 == 0){
                player.ace2 = 11;
                player.setPoints(11);
            }else if (player.ace3 == 0){
                player.ace3 = 11;
                player.setPoints(11);
            }else if(player.ace4 == 0){
                player.ace4 = 11;
                player.setPoints(11);
            }

        }else{
            player.setPoints(point);
        }
        return;
    }

for some reason when the points go over 21 this doesnt change the ace value and doesnt adjust the ace. any help will be appreciated. Thank you

Answer 1

Your code seems too complicated. Rather than having a variable for each ace, simply keep a count of the number of aces you have not reduced to a 1 :

private int fullAceCount;

update assuming 11 for an ace, but also update the ace count:

if (points == 11) { // if it's an ace
    fullAceCount++; // save it for later deduction
}

then after updating for any card, check if you you need to deduct 10

if (total > 21 && fullAceCount > 0) {
    total =- 10;
    fullAceCount--; // record that you've used up one of your aces
}

and you're done.