Create password protected ZIP file in PHP

Question

Hi i am Using Following Code For create password protected zip file

$password = 'pass';
$outfile = 'download.zip';    
$infile = 'xml.php';    
header("Content-type: application/octet-stream");   
header("Content-disposition: attachment; filename=$outfile");    
@system("zip -P $password $outfile $infile");    
readfile($outfile);    
@unlink($outfile);

but it is not working.

Answer 1

Same code is working for me. When i first ran this, i got permission error, when i gave the permission to folder, it worked. You can also check for folder permissions. It might also work for you.

Answer 2

Assuming your example is dumbed down and the password comes from somewhere else (maybe user input?), the system call is not safe! If it contains characters that have meaning to the shell, you'll get undesired result. Make sure you escape parameters with escapeshellarg: http://php.net/manual/en/function.escapeshellarg.php