change div id by javascript
Question
I've created a simple page to change the div id every time I pressed submit. My problem is that this changes from div_top1 -> div_top2, but the second time I press the button, it stops changing :(
<!DOCTYPE html>
<html>
<head>
<script>
function changediv()
{
document.getElementById("div_top1").innerHTML=Date();
document.getElementById("div_top1").setAttribute("id", "div_top2");
document.getElementById("div_top2").innerHTML="teste";
document.getElementById("div_top2").setAttribute("id", "div_top1");
}
</script>
<style>
.top {
background-color: navy;
color: white;
padding: 10px 10px 10px 10px;
margin: 5px 5px 5px 5px;
}
.down {
background-color: aqua;
padding: 10px 10px 10px 10px;
margin: 5px 5px 5px 5px;
}
</style>
</head>
<body>
<div id="div_top1" class="top">This is a paragraph.</div>
<div class="down"><button type="button" onclick="changediv()">Display Date</button></div>
</body>
</html>
3 answers
solution1
15 ACCPTED
Try this:
function changediv()
{
if (document.getElementById("div_top1")) {
document.getElementById("div_top1").innerHTML=Date();
document.getElementById("div_top1").setAttribute("id", "div_top2");
}
else {
document.getElementById("div_top2").innerHTML="teste";
document.getElementById("div_top2").setAttribute("id", "div_top1");
}
}
solution2
3 2013-05-16 10:04:51
The problem isn't the changing id - it's that you're changing it both ways every time. You need an if condition. You should also use .id to change the id instead of setAttribute() - I've had issues with some browsers in the past (many years ago) using setAttribute for id changes.
DEMO: http://jsfiddle.net/x2nPY/
function changediv() {
if (document.getElementById("div_top1")) {
document.getElementById("div_top1").innerHTML = Date();
document.getElementById("div_top1").id = "div_top2";
} else {
document.getElementById("div_top2").innerHTML = "teste";
document.getElementById("div_top2").id = "div_top1";
}
}
solution3
1 2013-05-16 10:07:47
You could use if for example if you want to toggle it or change every time you submit like:
function changediv() {
if (document.getElementById("div_top1"))
{
document.getElementById("div_top1").innerHTML=Date();
document.getElementById("div_top1").setAttribute("id", "div_top2");
}
else
{
document.getElementById("div_top2").innerHTML="teste";
document.getElementById("div_top2").setAttribute("id", "div_top1");
}
}
See the Fiddle Demo
The technical post webpages of this site follow the CC BY-SA 4.0 protocol. If you need to reprint, please indicate the site URL or the original address.Any question please contact:yoyou2525@163.com.