Can't bind ObservableCollection to Combobox in wpf

Question

I have the following xaml:

<UserControl.Resources>
    <sivm:Locator x:Key="viewModelLocator" ModelType="{x:Type ViewModels:RateVSConcentrationViewModel}"/>
</UserControl.Resources>

<UserControl.DataContext>
    <Binding Path="ViewModel" Source="{StaticResource viewModelLocator}"/>
</UserControl.DataContext>

...

<ComboBox Grid.Column="0" Grid.Row="1" Height="20" VerticalAlignment="Top" ItemsSource="{Binding Chambers}" > <!--SelectedItem="{Binding SelectedChamber}">-->
    <ComboBox.ItemTemplate>
        <DataTemplate>
            <TextBlock Text="{Binding ChamberName}"/>
        </DataTemplate>
    </ComboBox.ItemTemplate>
</ComboBox>

Chambers is an ObservableCollection of objects that contains a property called ChamberName which I want displayed in the combobox.

In the ViewModel I have the following code:

foreach (var chamber in chambers)
{
     Chambers.Add(chamber);
}
OnPropertyChanged(() => Chambers);

But when this code executes the combobox is not updated. I have used this way to do a lot of databinding but I can't get this to work.

Can someone see what I am doing wrong here?

Answer 1

You may need to set the relativesource on your textblock, try modifying the binding on the Text property of your textblock to the following:

{Binding DataContext.ChamberName, RelativeSource={RelativeSource AncestorType=ComboBox}}

And as nit said above, always check for binding errors, they will put you on the right path.

Answer 2

您应该按如下所示调整属性绑定：

<ComboBox ItemsSource="{Binding Path=ViewModel.Chambers, Source={StaticResource viewModelLocator}}" >

Answer 3

我做到了这一点：

<ComboBox DisplayMemberPath="ChamberName" Grid.Column="0" Grid.Row="1" Height="20" VerticalAlignment="Top" ItemsSource="{Binding Chambers}"> <!--SelectedItem="{Binding SelectedChamber}">-->