my php doesn't creat a new file to save my form data

Question

I wrote some code for a membership form for a church. When the form is submitted, it's supposed to create a new .txt file using the first name of the person filling the form. When I run the code, it works, I don't get an error message but the file doesn't get created. What am I doing wrong??

This is the php I wrote for it

    $Salutation = trim($_POST['salutation']);
    $FirstName = trim($_POST['firstname']);
    $OtherName = ($_POST['othernames']);
    $LastName = trim($_POST['lastname']);
    $Gender = trim($_POST['Gender']);
    $Nationality = trim($_POST['nationality']);
    $DOB = trim($_POST['DOB']);
    $POB = trim($_POST['POB']);
    $Marital_Status = trim($_POST['MarStat']);
    $Occupation = trim($_POST['occupation']);
    $Workplace = trim($_POST['POW']);
    $Residence = trim($_POST['POR']);
    $Children = trim($_POST['Kids']);
    $Postal = trim($_POST['postal']);
    $Telephone = trim($_POST['telephone']);
    $Email = trim($_POST['email']);
    $Diocese = trim($_POST['diocese']);
    $Branch = trim($_POST['branch']);
    $HowLongBornAgain = trim($_POST['lengthBornAgain']);
    $WhenJoinLCI = trim($_POST['WJLCI']);
    $Member_Type = trim($_POST['memtype']);
    $HowFind = trim($_POST['howFind']);
    $Who_Knows_Name = trim($_POST['whoknowname']);
    $Who_Know_Num = trim($_POST['whoknownum']);
    $Who_Know_Rel = trim($_POST['whoknowrel']);

    $data = "Name | $Salutaion $FirstName $OtherName $LastName\n
            Gender | $Gender\n
            Nationality | $Nationality\n
            Date of Birth | $DOB\n
            Place of Birth | $POB\n
            Marital Status | $Marital_Status\n
            Occupation | $Occupation\n
            Workplace | $Workplace\n
            Residence | $Residence\n
            Children | $Children\n
            Postal Address | $Postal\n
            Telephone | $Telephone\n
            E-mail | $Email\n
            Diocese | $Diocese\n
            Branch | $Branch\n
            Years Born Again | $HowLongBornAgain\n
            When $Salutation $LastName joined LCI | $WhenJoinLCI\n
            Member Type | $Member_Type\n
            Found Lighthouse through | $HowFind\n
            Person Who Knows Member | $Who_Knows_Name\n
            $Who_Knows_Name \'s number | $Who_Know_Num\n
            Relationship between the two members | $Who_Know_Rel\n":

    $myfile = $Salutaion." ".$FirstName." ".$OtherName." ".$LastName.".txt";

    $create_file = fopen($myfile, w) or die("Can't open file.");
    fwrite($create_file, $data) or die("Couldn\'t write values to file.");

    fclose($create_file);



}

Answer 1

In ANSWER to the question:

your $data string has : instead of ; at the end.

This will cause your php script to fail before even getting to creating the file name.

Hence no error