Selenium WaitForElement in c# throws ElementNotVisibleException

Question

IWebDriver driver = Browser.Instance.Driver;

if (timeout > 0)
{
    WebDriverWait wait = new WebDriverWait(driver, TimeSpan.FromSeconds(timeout));
    try
    {
        wait.Until(ExpectedConditions.ElementExists(selector));
        return driver.FindElement(selector);
    }
    catch(NoSuchElementException)
    {
        throw new NoSuchElementException();
    }
}
else
{
    // Search for element without timeout 
    return driver.FindElement(selector);
}

This is my code and i really don't know why it is throwing an Exception here. My timout is set to 30 seconds but he throws the Exception after a couple seconds already. When i run the Test in Debug Modus and wait for the Element myself, it works fine.

At first I used this, but didn't work either

var wait = new WebDriverWait(driver, TimeSpan.FromSeconds(timeoutInSeconds));
return wait.Until(drv => drv.FindElement(by));</code>

Answer 1

ExpectedConditions.ElementExists(); is waiting for the element to exists in the DOM . To make sure the element is visible in the website use ExpectedConditions.ElementIsVisible()

wait.Until(ExpectedConditions.ElementIsVisible(selector));

As a side not, if wait.Until condition doesn't met it throws WebDriverTimeoutException , not NoSuchElementException .