简体   繁体   中英

How can I turn this into a loop?

I'm trying to make this even cleaner, I've shortened dozens of lines to this, but need to loop through my column/dropdown values and run them through the function. I'm blanking.

function populateDropdowns (dropdownObject) {
$.ajax({
    url: "website eq '"+dropdownObject.column+"'",
    type: "GET",
    headers: {
        "accept": "application/json;odata=verbose",
        },
        success: function (data) {
            var authOne = (data.d.results[0].Choices.results);
            $(dropdownObject.dropdown).empty();
            $.each(authOne, function(i, p) {
                $(dropdownObject.dropdown).append($('<option></option>').val(p).html(p));
            });
        },
        error: function (error) {
            alert(JSON.stringify(error));
        }
    });
}
var dropdownObject = {};
dropdownObject = {column:"value1", dropdown:'#id1'}; populateDropdowns(dropdownObject);
dropdownObject = {column:"value2", dropdown:'#id2'}; populateDropdowns(dropdownObject);
dropdownObject = {column:"value3", dropdown:'#id3'}; populateDropdowns(dropdownObject);
dropdownObject = {column:"value4", dropdown:'#id4'}; populateDropdowns(dropdownObject);
dropdownObject = {column:"value5", dropdown:'#id5'}; populateDropdowns(dropdownObject);

If your values are fixed till 5, then a for loop should work fine.

for(var i = 1; i < 6; i++){
    populateDropdowns( {column : "value" + i, dropdown:'#id' + i});
}

EDIT 1: If values are not sequential, then you can pass Objects array to a forEach loop.

var dropdowns = [
  {column: "value1", dropdown: "#id1"},
  {column: "value2", dropdown: "#id2"},
  {column: "value3", dropdown: "#id3"},
  {column: "value4", dropdown: "#id4"},
  {column: "value5", dropdown: "#id5"}
;

dropdowns.forEach(dropdown => populateDropdowns(dropdown));

If you want to loop through some data, the data should probably be in an array:

const dropdownObjects = [
  { column: 'value1', dropdown: '#id1' },
  { column: 'value2', dropdown: '#id2' },
  { column: 'value3', dropdown: '#id3' },
  // ...
];

for (var i = 0; i < dropdownObjects.length; i++) {
  populateDropdowns(dropdownObjects[i]);
}

Or, more succinctly:

dropdownObjects.forEach(populateDropdowns);

The technical post webpages of this site follow the CC BY-SA 4.0 protocol. If you need to reprint, please indicate the site URL or the original address.Any question please contact:yoyou2525@163.com.

 
粤ICP备18138465号  © 2020-2024 STACKOOM.COM