Whats wrong with my LinkedList remove method

Question

What's wrong with my remove function, I can remove head but cannot remove any other node.

 SLinkedList.prototype.remove = function(value) { if(!this.findValue(value) )return; if(this.head.value === value){ this.head = this.head.next; return; } var prev = null; var cur = this.head; while(cur.value !== value){ prev = cur; cur = cur.next } prev.next = cur.next; } 

This is a link to full javascript implementation repl it

Answer 1

There are two errors in your fineValue() method. First your while loop was looking at this.head which was never changing. Second you were returning false after the first iteration. Hope this helps.

SLinkedList.prototype.findValue = function(value) {
 if (!this.head) return false
  var cur = this.head;
  while (cur) { //Need to check cur not this.head
   if (cur.value === value) {
    return true
   }
   cur = cur.next
   //return false; //Move this out of the while loop
 }
 return false
}