简体   繁体   中英

Angular2 Injecting Service into another Service

I can't find my error.

app.module.ts
    ...
    providers: [ValidateService,AuthService]
    ...

I do the following in my register.component.ts:

import {AuthService} from '../../services/auth.service';
...
constructor( private _validateService: ValidateService,
               private _fms: FlashMessagesService,
               private _authService: AuthService,
               private _router: Router
               ) { }
...
ngOnInit() { 
      this._authService.uniqueUser({username:'zomh'}).subscribe(data => {
      console.log("data.success: "+data.success);       
      if(!data.success) {   // Username already exists       
        console.log('exists');
      }
      else {
         console.log('does not exist');
      }
      });
  }

Works as expected the user is already in the database therefore I get the a user exists in the console.

I do pretty pretty much the very same thing (I broke it down to this point) in my validate.service.ts:

import { AuthService } from './auth.service';
import { Injectable } from '@angular/core';
import { FormControl } from '@angular/forms';



@Injectable()
export class ValidateService {

  constructor( public _authService: AuthService) { }

  validateRegister(user) {
    if(user.name == undefined || user.email == undefined || user.username == undefined || user.password == undefined)
      return false;
    else
      return true;
  }

  validateEmailPattern(c: FormControl) {
     const re = /^(([^<>()\[\]\\.,;:\s@"]+(\.[^<>()\[\]\\.,;:\s@"]+)*)|(".+"))@((\[[0-9]{1,3}\.[0-9]{1,3}\.[0-9]{1,3}\.[0-9]{1,3}])|(([a-zA-Z\-0-9]+\.)+[a-zA-Z]{2,}))$/;

     if (re.test(c.value))
      return null;
     else
      return {invalidPattern:true};

  }
  validateUsernamePattern(c: FormControl) {
    const re = /^[A-Za-z0-9]+(?:[ _-][A-Za-z0-9]+)*$/

    if (re.test(c.value))
      return null;
    else
      return {invalidPattern:true};

  }
  validateUsernameIsUnique (c: FormControl) {

    let ret:any;
    if (c.value.length >= 3)
    {
      console.log(c.value);
      this._authService.uniqueUser({username:'zomh'}).subscribe(data => {

      if(!data.success) {   // Username already exists       
        console.log('call from service: exists');
      }
      else {
         console.log('call from service: does not exist');
      }
      });

    }

    return {usernameIsTaken:true};
  }


}

But here I get a Cannot read property _authService of undefined Exception 在此处输入图片说明

For me it looks like the service did not inject correctly. But I can't find my error.

Update 1: So i did copy the auth Service call into the Constructor and its working. Therefore it has to be some this. related error (?) i can't get the value of this._authService from any other method outside of the constructor ?

@Injectable()
export class ValidateService {

  constructor( private _authService: AuthService ) { 

        this._authService.uniqueUser({ username: 'zomh' }).subscribe(data => {

        if (!data.success) {   // Username already exists       
          console.log('call from service: exists');
        }
        else {
          console.log('call from service: does not exist');
        }
      });
  }

I dont think you can have a new line between @Injectable and export class ValidateService {

Try it without that line.

After reading an article I rewrote my method into an instance method:

 validateUsernameIsUnique = (c: FormControl) => {

    let ret: any;
    if (c.value.length >= 3) {      
      this._authService.uniqueUser({ username: c.value }).subscribe(data => {

        if (!data.success) {   // Username already exists       
          console.log('call from service: exists');
        }
        else {
          console.log('call from service: does not exist');
        }
      });

    }
...

It fixed the problem. I am still not sure why this had to be done though, feel free to add knowledge

The technical post webpages of this site follow the CC BY-SA 4.0 protocol. If you need to reprint, please indicate the site URL or the original address.Any question please contact:yoyou2525@163.com.

 
粤ICP备18138465号  © 2020-2024 STACKOOM.COM