Ember computed property adds comma

Question

I created a computed property to concat two model properties together, and create a list of them. It initially worked like this, which results in a list like so: prop1-prop2, prop1-prop2

modelName: Ember.computed(
  return this.get('modelName').map((o) => {
    return o.get('prop1') + '-' + o.get('prop2');
  }).join(', ');
})

Then I changed it to this which results in the same list:

modelName: Ember.computed(
  return this.get('modelName').map((o, i) => {
    return (i > 0 ? ' ' : '') + o.get('prop1') + '-' + o.get('prop2');
  });
})

My question is, where is the second computed property getting the comma to put in the comma-separated list? The initial code I tried was (i > 0 ? ', ' : '') but that was adding two commas. Can anyone explain?

Answer 1

You forgot to return the result.

modelName: Ember.computed('modelName',
  return this.get('modelName').map((o, i) => {
    return (i > 0 ? ' ' : '') + o.get('prop1') + '-' + o.get('prop2');
  });
})

and also I will encourage you to have dependant key modelName