Response.Redirect not redirecting to a specific URL in ASP.NET MVC

Question

I am trying to redirect to some page after login.

Here is my code

ViewBag.userid = Session[Declaration.sUserID];
var userid = ViewBag.userid;
if (userid == null)
{
    Response.Redirect("signin?url=" + Server.UrlEncode(Request.Url.AbsoluteUri));
}
else
{
    string ReturnUrl = Convert.ToString(Request.QueryString["url"]);
    if (!string.IsNullOrEmpty(ReturnUrl))
    {
        Response.Redirect(ReturnUrl);//http://localhost:55197/usermanagement
    }
    else
    {
        return RedirectToAction("DashBoard");
    }
}
return View();

The problem is that it is not redirecting from Response.Redirect part and always calls the same view again and gain.

Someone have an idea why it's happening?

Answer 1

You need to "return" once you call Response.Redirect, otherwise the code will continue and eventually call return View(), which returns the original view back to the caller. eg

ViewBag.userid = Session[Declaration.sUserID];

    var userid = ViewBag.userid;
    if (userid == null)
    {
        return Redirect("signin?url=" + Server.UrlEncode(Request.Url.AbsoluteUri));
    }
    else
    {
        string ReturnUrl = Convert.ToString(Request.QueryString["url"]);
        if (!string.IsNullOrEmpty(ReturnUrl))
        {
            return Redirect(ReturnUrl);//http://localhost:55197/usermanagement
        }
        else
        {
            return RedirectToAction("DashBoard");
        }
    }


    return View();